Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: scripts/slave/recipes/bisect_test/example_bisect_results.py

Issue 1801843002: Revert of Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/bisect_test/example_bisect_results.py
diff --git a/scripts/slave/recipes/bisect_test/example_bisect_results.py b/scripts/slave/recipes/bisect_test/example_bisect_results.py
index efda0a2926e573ebc75fa6a73824c18bc03b947c..09f625fc852567d27319579349b56b3d21c172aa 100644
--- a/scripts/slave/recipes/bisect_test/example_bisect_results.py
+++ b/scripts/slave/recipes/bisect_test/example_bisect_results.py
@@ -90,11 +90,9 @@
def add_revision_mapping(api, test, pos, sha):
- step_name = ('Resolving reference range.crrev get commit hash for ' +
- 'refs/heads/master@{#%s}' % pos)
- stdout = api.json.output({'git_sha': sha})
+ step_name = 'Resolving reference range.resolving commit_pos ' + pos
+ stdout = api.raw_io.output('hash:' + sha)
test += api.step_data(step_name, stdout=stdout)
-
step_name = 'Resolving reference range.resolving hash ' + sha
pos = 'refs/heads/master@{#%s}' % pos
stdout = api.raw_io.output(pos)

Powered by Google App Engine
This is Rietveld 408576698