Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: core/fxge/dib/fx_dib_main.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fxge/dib/fx_dib_main.cpp
diff --git a/core/fxge/dib/fx_dib_main.cpp b/core/fxge/dib/fx_dib_main.cpp
index 8ce20568df39b1c443980cccdb74728167cb83ed..caa8836f2b28363b5a89789bbc4bed063061553b 100644
--- a/core/fxge/dib/fx_dib_main.cpp
+++ b/core/fxge/dib/fx_dib_main.cpp
@@ -1240,8 +1240,12 @@ FX_BOOL CFX_DIBitmap::ConvertColorScale(FX_DWORD forecolor,
if (!m_pBuffer || IsAlphaMask()) {
return FALSE;
}
- int fc, fm, fy, fk, bc, bm, by, bk;
- int fr, fg, fb, br, bg, bb;
+ // Values used for CMYK colors.
+ int fc = 0, fm = 0, fy = 0, fk = 0;
dsinclair 2016/03/16 13:23:32 nit: one per line
Wei Li 2016/03/16 17:51:31 Done.
+ int bc = 0, bm = 0, by = 0, bk = 0;
Tom Sepez 2016/03/16 18:34:59 Stunning lack of duplication between the isCmykIma
Wei Li 2016/03/17 02:24:05 Acknowledged.
+ // Values used for RGB colors.
+ int fr = 0, fg = 0, fb = 0;
+ int br = 0, bg = 0, bb = 0;
FX_BOOL isCmykImage = IsCmykImage();
if (isCmykImage) {
fc = FXSYS_GetCValue(forecolor);

Powered by Google App Engine
This is Rietveld 408576698