Re-enable several MSVC warnings

core/fxge/dib/fx_dib_main.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fxge/fx_dib.h"
 
 #include <limits.h>
 
@@ skipping 1218 matching lines @@
       src_x %= m_Width * src_Bpp;
       int dest_pos = i * src_Bpp;
       for (int b = 0; b < src_Bpp; b++) {
         dest_scan[dest_pos + b] = scanline[src_x + b];
       }
     }
   }
 }
 FX_BOOL CFX_DIBitmap::ConvertColorScale(FX_DWORD forecolor,
                                         FX_DWORD backcolor) {
   ASSERT(!IsAlphaMask());

[Tom Sepez, 2016/03/16 18:34:59]

We can lose the assert here since we handle it at 1240

[Wei Li, 2016/03/17 02:24:05]

assert is for debugging purpose? leave it here for now.

   if (!m_pBuffer || IsAlphaMask()) {
     return FALSE;
   }
-  int fc, fm, fy, fk, bc, bm, by, bk;
-  int fr, fg, fb, br, bg, bb;
+  // Values used for CMYK colors.
+  int fc = 0, fm = 0, fy = 0, fk = 0;

[dsinclair, 2016/03/16 13:23:32]

nit: one per line

[Wei Li, 2016/03/16 17:51:31]

Done.

+  int bc = 0, bm = 0, by = 0, bk = 0;

[Tom Sepez, 2016/03/16 18:34:59]

Stunning lack of duplication between the isCmykImage and !isCmykImage paths. 
I'd suggest splitting this into two helper functions.

[Wei Li, 2016/03/17 02:24:05]

Acknowledged.

+  // Values used for RGB colors.
+  int fr = 0, fg = 0, fb = 0;
+  int br = 0, bg = 0, bb = 0;
   FX_BOOL isCmykImage = IsCmykImage();
   if (isCmykImage) {
     fc = FXSYS_GetCValue(forecolor);
     fm = FXSYS_GetMValue(forecolor);
     fy = FXSYS_GetYValue(forecolor);
     fk = FXSYS_GetKValue(forecolor);
     bc = FXSYS_GetCValue(backcolor);
     bm = FXSYS_GetMValue(backcolor);
     by = FXSYS_GetYValue(backcolor);
     bk = FXSYS_GetKValue(backcolor);
@@ skipping 481 matching lines @@
   if (!m_pBitmap->Create(width, height, src_format)) {
     delete m_pBitmap;
     m_pBitmap = NULL;
     return FALSE;
   }
   if (pSrcPalette) {
     m_pBitmap->CopyPalette(pSrcPalette);
   }
   return TRUE;
 }