core/fxge/ge/fx_ge_font.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/ge/fx_ge_font.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/ge/fx_ge_font.cpp

diff --git a/core/fxge/ge/fx_ge_font.cpp b/core/fxge/ge/fx_ge_font.cpp

index 67b968b44d4a4752be13071fd360501dc2a5df2b..098195dded870fb02715f54cc073772dcb3f0a2d 100644

--- a/core/fxge/ge/fx_ge_font.cpp

+++ b/core/fxge/ge/fx_ge_font.cpp

@@ -522,7 +522,7 @@ FX_DWORD CFX_UnicodeEncodingEx::CharCodeFromUnicode(FX_WCHAR Unicode) const {

return Unicode;

}

- return -1;

+ return static_cast<FX_DWORD>(-1);

dsinclair 2016/03/16 13:23:32 Ditto: FX_DWORD is a uint64

Wei Li 2016/03/16 17:51:31 Done.

Tom Sepez 2016/03/16 18:34:59 Nah, s'awwright.

Wei Li 2016/03/17 02:24:05 Now I checked more carefully. Looks like -1 used a

}

CFX_UnicodeEncodingEx* FX_CreateFontEncodingEx(CFX_Font* pFont,