Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1800293004: Speculative fix for the NPE in dispatchGetDisplayList (Closed)

Created:
4 years, 9 months ago by Ted C
Modified:
4 years, 9 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for the NPE in dispatchGetDisplayList In https://codereview.chromium.org/1638303002, we began potentially removing the overscroll refresh layout at the end of the animations. According to this article: http://stackoverflow.com/questions/15636658/nullpointerexception-when-adding-removing-views-of-a-relativelayout-animations That could potentially be the source of the crashes we are seeing. Changing it to post the detach instead of calling it synchronously in the animation listener. BUG=590359 Committed: https://crrev.com/27d091d7ac6fdbb88d593c92d515c2a8d63544fc Cr-Commit-Position: refs/heads/master@{#381595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java View 5 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 9 months ago (2016-03-16 20:15:58 UTC) #2
Theresa
lgtm
4 years, 9 months ago (2016-03-16 20:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800293004/1
4 years, 9 months ago (2016-03-16 23:24:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 00:08:07 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 00:09:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27d091d7ac6fdbb88d593c92d515c2a8d63544fc
Cr-Commit-Position: refs/heads/master@{#381595}

Powered by Google App Engine
This is Rietveld 408576698