Detach SwipeRefreshLayout when it's animation ends

Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
Committed: https://crrev.com/2a483b32bafb708c0b575507700e8e8769c9f472
Cr-Commit-Position: refs/heads/master@{#372048}

[xiangze.zhang, 2016-01-27 08:49:04]

Description was changed from

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
==========

to

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
==========

[xiangze.zhang, 2016-01-27 08:49:04]

xiangze.zhang@intel.com changed reviewers:
+ aurimas@chromium.org, jdduke@chromium.org, tedchoc@chromium.org

[xiangze.zhang, 2016-01-27 08:54:54]

On 2016/01/27 08:49:04, xiangze.zhang wrote:
> mailto:xiangze.zhang@intel.com changed reviewers:
> + mailto:aurimas@chromium.org, mailto:jdduke@chromium.org,
mailto:tedchoc@chromium.org

Hi, tedchoc@, aurimas@, jdduke@: PTAL

[Ted C, 2016-01-27 18:46:56]

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
File
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java
(right):

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:168:
mResetListener.onReset();
I think you should move this to reset.

Also, you need to null check mResetListener.

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:319:
public void setOnResetListener(OnResetListener listener) {
javadoc

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:806:
public interface OnResetListener {
javadoc

[xiangze.zhang, 2016-01-28 02:33:29]

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
File
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java
(right):

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:168:
mResetListener.onReset();
On 2016/01/27 18:46:55, Ted C wrote:
> I think you should move this to reset.
> 
> Also, you need to null check mResetListener.

Done.

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:319:
public void setOnResetListener(OnResetListener listener) {
On 2016/01/27 18:46:56, Ted C wrote:
> javadoc

Done.

https://codereview.chromium.org/1638303002/diff/1/third_party/android_swipe_r...
third_party/android_swipe_refresh/java/src/org/chromium/third_party/android/swiperefresh/SwipeRefreshLayout.java:806:
public interface OnResetListener {
On 2016/01/27 18:46:56, Ted C wrote:
> javadoc

Done.

[Ted C, 2016-01-28 03:09:05]

lgtm

[xiangze.zhang, 2016-01-28 07:20:37]

The CQ bit was checked by xiangze.zhang@intel.com

[commit-bot: I haz the power, 2016-01-28 07:20:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1638303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1638303002/20001

[commit-bot: I haz the power, 2016-01-28 08:09:10]

Description was changed from

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
==========

to

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
==========

[commit-bot: I haz the power, 2016-01-28 08:09:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 08:10:17]

Description was changed from

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626
==========

to

==========
Detach SwipeRefreshLayout when it's animation ends

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626

Committed: https://crrev.com/2a483b32bafb708c0b575507700e8e8769c9f472
Cr-Commit-Position: refs/heads/master@{#372048}
==========

[commit-bot: I haz the power, 2016-01-28 08:10:18]

Patchset 2 (id:??) landed as
https://crrev.com/2a483b32bafb708c0b575507700e8e8769c9f472
Cr-Commit-Position: refs/heads/master@{#372048}