Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java

Issue 1800293004: Speculative fix for the NPE in dispatchGetDisplayList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java
index 1f030dbbf56a5030d033212164381350113d5679..45677771637fefaf3e6e47a06ad38f1d6d105bd1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java
@@ -42,6 +42,10 @@ public class SwipeRefreshHandler implements OverscrollRefreshHandler {
// loads a frame. This is used to provide a reasonable minimum animation time.
private Runnable mStopRefreshingRunnable;
+ // Handles removing the layout from the view hierarchy. This is posted to ensure it does not
+ // conflict with pending Android draws.
+ private Runnable mDetachLayoutRunnable;
+
// Accessibility utterance used to indicate refresh activation.
private String mAccessibilityRefreshString;
@@ -100,7 +104,15 @@ public class SwipeRefreshHandler implements OverscrollRefreshHandler {
mSwipeRefreshLayout.setOnResetListener(new SwipeRefreshLayout.OnResetListener() {
@Override
public void onReset() {
- detachSwipeRefreshLayoutIfNecessary();
+ if (mDetachLayoutRunnable != null) return;
+ mDetachLayoutRunnable = new Runnable() {
+ @Override
+ public void run() {
+ mDetachLayoutRunnable = null;
+ detachSwipeRefreshLayoutIfNecessary();
+ }
+ };
+ mSwipeRefreshLayout.post(mDetachLayoutRunnable);
}
});
@@ -157,6 +169,13 @@ public class SwipeRefreshHandler implements OverscrollRefreshHandler {
}
}
+ private void cancelDetachLayoutRunnable() {
+ if (mDetachLayoutRunnable != null) {
+ mSwipeRefreshLayout.removeCallbacks(mDetachLayoutRunnable);
+ mDetachLayoutRunnable = null;
+ }
+ }
+
private Runnable getStopRefreshingRunnable() {
if (mStopRefreshingRunnable == null) {
mStopRefreshingRunnable = new Runnable() {
@@ -172,6 +191,7 @@ public class SwipeRefreshHandler implements OverscrollRefreshHandler {
// The animation view is attached/detached on-demand to minimize overlap
// with composited SurfaceView content.
private void attachSwipeRefreshLayoutIfNecessary() {
+ cancelDetachLayoutRunnable();
if (mContentViewCore == null) return;
if (mSwipeRefreshLayout.getParent() == null) {
mContentViewCore.getContainerView().addView(mSwipeRefreshLayout);
@@ -179,6 +199,7 @@ public class SwipeRefreshHandler implements OverscrollRefreshHandler {
}
private void detachSwipeRefreshLayoutIfNecessary() {
+ cancelDetachLayoutRunnable();
if (mContentViewCore == null) return;
if (mSwipeRefreshLayout.getParent() != null) {
mContentViewCore.getContainerView().removeView(mSwipeRefreshLayout);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698