Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1800183004: Expose accessible descriptions on Android. (Closed)

Created:
4 years, 9 months ago by dmazzoni
Modified:
4 years, 8 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_create_bam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose accessible descriptions on Android. Improve handling of accessible text by exposing the accessible name of an element in "text" for text fields and "contentDescription" otherwise, and by exposing the accessible description (secondary) as the name of the SELECT accessibility action, which is a nice trick to get TalkBack to announce that text after a short delay. BUG=592297

Patch Set 1 #

Patch Set 2 : Fix text fields #

Total comments: 5

Messages

Total messages: 3 (1 generated)
dmazzoni
4 years, 9 months ago (2016-03-16 20:47:15 UTC) #2
David Tseng
4 years, 9 months ago (2016-03-17 22:55:15 UTC) #3
https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_android.cc (left):

https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:363: // Perhaps
we could return color names in the future?
Unrelated; this begs to be made into a TODO with a bug?

https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_android.cc (right):

https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:350: if
(!value.empty() && ShouldExposeValueAsName())
So, in the Android world, text is same as name?

What happens with text fields with a value and a name? Do we only show the value
in that case?

https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:404: //
accessible name as the only accessible text.
Can you reword this last part? Accessible text or description?

https://codereview.chromium.org/1800183004/diff/20001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:406: if
(!value.empty() && ShouldExposeValueAsName())
Can you move this non-empty value check into ShouldExposeValueAsName method?

https://codereview.chromium.org/1800183004/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/1800183004/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:46:
AccessibilityNodeInfo.ACTION_SELECT,
This action (according to the docs) is meant for selecting this node. If
TalkBack ever gets selection working, wouldn't we have no way to convey that
info? Just curious if that might be a concern.

Powered by Google App Engine
This is Rietveld 408576698