Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1800183004: Expose accessible descriptions on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_create_bam
Patch Set: Fix text fields Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index 506448db6e92e777466a7a4dcc483129d83cf63a..7ccf8180b7b962940de44f58dbc01c7effbe4cf0 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -404,10 +404,11 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(
base::android::ConvertUTF8ToJavaString(env, node->GetClassName()).obj());
if (!node->IsPassword() ||
Java_BrowserAccessibilityManager_shouldExposePasswordText(env, obj)) {
- Java_BrowserAccessibilityManager_setAccessibilityNodeInfoContentDescription(
+ Java_BrowserAccessibilityManager_setAccessibilityNodeInfoText(
env, obj, info,
base::android::ConvertUTF16ToJavaString(env, node->GetText()).obj(),
- node->IsLink());
+ node->IsLink(),
+ node->IsEditableText());
}
base::string16 element_id;
if (node->GetHtmlAttribute("id", &element_id)) {
@@ -444,7 +445,9 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(
node->IsDismissable(),
node->IsMultiLine(),
node->AndroidInputType(),
- node->AndroidLiveRegionType());
+ node->AndroidLiveRegionType(),
+ base::android::ConvertUTF16ToJavaString(
+ env, node->GetDescription()).obj());
if (node->IsCollection()) {
Java_BrowserAccessibilityManager_setAccessibilityNodeInfoCollectionInfo(
env, obj, info,

Powered by Google App Engine
This is Rietveld 408576698