Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 1800183004: Expose accessible descriptions on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_create_bam
Patch Set: Fix text fields Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
index 031e452bfa530c4c51efa94860c6abd3d0097e30..24394c693517e1269e3852f03e4cd5c7d947814e 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
@@ -833,14 +833,19 @@ public class BrowserAccessibilityManager {
@SuppressLint("NewApi")
@CalledByNative
- private void setAccessibilityNodeInfoContentDescription(
- AccessibilityNodeInfo node, String contentDescription, boolean annotateAsLink) {
+ private void setAccessibilityNodeInfoText(
+ AccessibilityNodeInfo node, String text, boolean annotateAsLink,
+ boolean isEditableText) {
+ CharSequence charSequence = text;
if (annotateAsLink) {
- SpannableString spannable = new SpannableString(contentDescription);
+ SpannableString spannable = new SpannableString(text);
spannable.setSpan(new URLSpan(""), 0, spannable.length(), 0);
- node.setContentDescription(spannable);
+ charSequence = spannable;
+ }
+ if (isEditableText) {
+ node.setText(charSequence);
} else {
- node.setContentDescription(contentDescription);
+ node.setContentDescription(charSequence);
}
}
@@ -916,7 +921,8 @@ public class BrowserAccessibilityManager {
boolean dismissable,
boolean multiLine,
int inputType,
- int liveRegion) {
+ int liveRegion,
+ String description) {
// Requires Lollipop or higher.
}

Powered by Google App Engine
This is Rietveld 408576698