Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 180013002: Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero exten… (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero extended. BUG=345820 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/x64/disasm-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-345820.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-25 15:57:54 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-25 16:11:27 UTC) #2
Igor Sheludko
6 years, 10 months ago (2014-02-25 16:34:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19549 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698