src/x64/lithium-gap-resolver-x64.cc - Issue 180013002: Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero exten…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-gap-resolver-x64.cc

Issue 180013002: Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero exten… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-gap-resolver-x64.cc

diff --git a/src/x64/lithium-gap-resolver-x64.cc b/src/x64/lithium-gap-resolver-x64.cc

index 5b4e32d2c44cec51bbe3b6f8684addd610272614..c3bfd9e61203243d53023ae064bbd5b3dbe41eee 100644

--- a/src/x64/lithium-gap-resolver-x64.cc

+++ b/src/x64/lithium-gap-resolver-x64.cc

@@ -198,7 +198,7 @@ void LGapResolver::EmitMove(int index) {

if (cgen_->IsSmiConstant(constant_source)) {

__ Move(dst, cgen_->ToSmi(constant_source));

} else if (cgen_->IsInteger32Constant(constant_source)) {

- __ Set(dst, cgen_->ToInteger32(constant_source));

+ __ Set(dst, static_cast<uint32_t>(cgen_->ToInteger32(constant_source)));

} else {

__ Move(dst, cgen_->ToHandle(constant_source));

}

« no previous file with comments | « src/x64/disasm-x64.cc ('k') | test/mjsunit/regress/regress-crbug-345820.js » ('j') | no next file with comments »