Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1799933002: Ensure embedder timeline callbacks are called for service protocol requests (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
rmacnak, Chinmay
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure embedder timeline callbacks are called for service protocol requests BUG= R=chinmaygarde@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9bc7398eb89ef4d80b8a4914bc88bb3bef312350

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -19 lines) Patch
M runtime/platform/text_buffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/platform/text_buffer.cc View 1 chunk +7 lines, -0 lines 2 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +6 lines, -17 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/json_stream.h View 3 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/json_stream.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M runtime/vm/json_test.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/timeline.cc View 5 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 9 months ago (2016-03-14 22:24:40 UTC) #3
Chinmay
On 2016/03/14 at 22:24:40, johnmccutchan wrote: > lgtm. After patching this in, I was able ...
4 years, 9 months ago (2016-03-14 23:01:11 UTC) #4
rmacnak
lgtm w/c https://codereview.chromium.org/1799933002/diff/1/runtime/platform/text_buffer.cc File runtime/platform/text_buffer.cc (right): https://codereview.chromium.org/1799933002/diff/1/runtime/platform/text_buffer.cc#newcode53 runtime/platform/text_buffer.cc:53: for (intptr_t i = 0; i < ...
4 years, 9 months ago (2016-03-14 23:08:12 UTC) #5
Cutch
https://codereview.chromium.org/1799933002/diff/1/runtime/platform/text_buffer.cc File runtime/platform/text_buffer.cc (right): https://codereview.chromium.org/1799933002/diff/1/runtime/platform/text_buffer.cc#newcode53 runtime/platform/text_buffer.cc:53: for (intptr_t i = 0; i < buffer_length; i++) ...
4 years, 9 months ago (2016-03-15 14:58:17 UTC) #6
Cutch
4 years, 9 months ago (2016-03-15 14:59:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9bc7398eb89ef4d80b8a4914bc88bb3bef312350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698