runtime/vm/dart_api_impl_test.cc - Issue 1799933002: Ensure embedder timeline callbacks are called for service protocol requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 1799933002: Ensure embedder timeline callbacks are called for service protocol requests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index 6c6fb8f9a9242bff28a11af41034f07a61e4ab11..4be3fa900393a10a18c4aab80a8e2d2a7e1cc36f 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -9827,7 +9827,7 @@ TEST_CASE(Timeline_Dart_EmbedderTimelineGetTimeline) {

bool success = Dart_GlobalTimelineGetTrace(AppendStreamConsumer, &data);

EXPECT(success);

- EXPECT_SUBSTRING("HELLO FROM EMBEDDER,{\"name\":\"testDurationEvent\"",

+ EXPECT_SUBSTRING("}},HELLO FROM EMBEDDER",

data.buffer);

// Free buffer allocated by AppendStreamConsumer

« runtime/platform/text_buffer.cc ('K') | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »