Ensure embedder timeline callbacks are called for service protocol requests

runtime/platform/text_buffer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/text_buffer.h"
 
 #include "platform/assert.h"
 #include "platform/globals.h"
 #include "platform/utils.h"
 #include "vm/os.h"
@@ skipping 30 matching lines @@
 
 
 void TextBuffer::AddChar(char ch) {
   EnsureCapacity(sizeof(ch));
   buf_[msg_len_] = ch;
   msg_len_++;
   buf_[msg_len_] = '\0';
 }
 
 
+void TextBuffer::AddRaw(const uint8_t* buffer,
+                        intptr_t buffer_length) {
+  for (intptr_t i = 0; i < buffer_length; i++) {

[rmacnak, 2016/03/14 23:08:11]

Why not

EnsureCapacity(buffer_length)
memmov(&buf_[msg_len_], buffer, buffer_length);
msg_len_ += buffer_length;
buf_[msg_len_] = '\0';

?

[Cutch, 2016/03/15 14:58:17]

Done.

+    AddChar(buffer[i]);
+  }
+}
+
 intptr_t TextBuffer::Printf(const char* format, ...) {
   va_list args;
   va_start(args, format);
   intptr_t remaining = buf_size_ - msg_len_;
   ASSERT(remaining >= 0);
   intptr_t len = OS::VSNPrint(buf_ + msg_len_, remaining, format, args);
   va_end(args);
   if (len >= remaining) {
     EnsureCapacity(len);
     remaining = buf_size_ - msg_len_;
@@ skipping 87 matching lines @@
     // the debugger front-end.
     intptr_t new_size = buf_size_ + len + kBufferSpareCapacity;
     char* new_buf = reinterpret_cast<char*>(realloc(buf_, new_size));
     ASSERT(new_buf != NULL);
     buf_ = new_buf;
     buf_size_ = new_size;
   }
 }
 
 }  // namespace dart