|
Refactors parts of gin:
. Runner no longer extends ContextHolder. It will still have a
ContextHolder, but not own it. This enables a couple of
things:
. Runner no longer need own a v8::Context.
. Runner can be lazily created after the ContextHolder.
. Runner becomes a (mostly) pure virtual interface. This enables an
implementation to execute through blink rather than v8 directly.
. What was Runner is now DefaultRunner (and
DefaultRunnerDelegate). I'm not a fan of these names, if you have
better ideas let me know. Maybe DirectRunner?
BUG=none
TEST=none
R=abarth@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253732
Total comments: 1
Total comments: 2
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+259 lines, -217 lines) |
Patch |
|
M |
gin/converter.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
gin/gin.gyp
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
gin/modules/module_registry.cc
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
gin/modules/module_runner_delegate.h
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
gin/modules/module_runner_delegate.cc
|
View
|
1
2
3
4
|
2 chunks |
+14 lines, -12 lines |
0 comments
|
Download
|
|
M |
gin/modules/timer.cc
|
View
|
1
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
gin/modules/timer_unittest.cc
|
View
|
1
2
3
4
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
gin/per_context_data.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
gin/public/context_holder.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
gin/runner.h
|
View
|
1
|
2 chunks |
+15 lines, -36 lines |
0 comments
|
Download
|
|
M |
gin/runner.cc
|
View
|
|
1 chunk |
+4 lines, -92 lines |
0 comments
|
Download
|
|
D |
gin/runner_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
|
M |
gin/shell/gin_main.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
A |
gin/shell_runner.h
|
View
|
1
2
3
4
5
|
1 chunk |
+68 lines, -0 lines |
0 comments
|
Download
|
|
A |
gin/shell_runner.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+112 lines, -0 lines |
0 comments
|
Download
|
|
A + |
gin/shell_runner_unittest.cc
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
gin/test/file_runner.h
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
gin/test/file_runner.cc
|
View
|
1
2
3
4
|
4 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
mojo/apps/js/bindings/gl/context.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/apps/js/bindings/waiting_callback.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/apps/js/main.cc
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/apps/js/mojo_runner_delegate.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
mojo/apps/js/mojo_runner_delegate.cc
|
View
|
1
2
3
4
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
mojo/apps/js/test/run_js_tests.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 17 (0 generated)
|