mojo/apps/js/bindings/waiting_callback.cc - Issue 179803007: Refactors parts of gin:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/bindings/waiting_callback.cc

Issue 179803007: Refactors parts of gin: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix gin_shell Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/apps/js/bindings/waiting_callback.cc

diff --git a/mojo/apps/js/bindings/waiting_callback.cc b/mojo/apps/js/bindings/waiting_callback.cc

index 87c28bf3ba7c895261d7312b0364f6c0ef59df84..923431630d3a2f38eae85c942a8f770442f34655 100644

--- a/mojo/apps/js/bindings/waiting_callback.cc

+++ b/mojo/apps/js/bindings/waiting_callback.cc

@@ -48,7 +48,7 @@ void WaitingCallback::OnHandleReady(MojoResult result) {

return;

gin::Runner::Scope scope(runner_.get());

- v8::Isolate* isolate = runner_->isolate();

+ v8::Isolate* isolate = runner_->GetContextHolder()->isolate();

v8::Handle<v8::Value> hidden_value =

GetWrapper(isolate)->GetHiddenValue(GetHiddenPropertyName(isolate));

« no previous file with comments | « mojo/apps/js/bindings/gl/context.cc ('k') | mojo/apps/js/main.cc » ('j') | no next file with comments »