Revert of Collect information about failing histogram factory calls.

base/metrics/histogram_persistence.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_persistence.h"
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
@@ skipping 226 matching lines @@
     NOTREACHED();
     return nullptr;
   }
 
   // Copy the histogram_data to local storage because anything in persistent
   // memory cannot be trusted as it could be changed at any moment by a
   // malicious actor that shares access. The contents of histogram_data are
   // validated below; the local copy is to ensure that the contents cannot
   // be externally changed between validation and use.
   PersistentHistogramData histogram_data = *histogram_data_ptr;
-  CHECK_EQ(histogram_data.histogram_type, histogram_data_ptr->histogram_type);
-  CHECK_EQ(histogram_data.flags, histogram_data_ptr->flags);
-  CHECK_EQ(histogram_data.minimum, histogram_data_ptr->minimum);
-  CHECK_EQ(histogram_data.maximum, histogram_data_ptr->maximum);
-  CHECK_EQ(histogram_data.bucket_count, histogram_data_ptr->bucket_count);
-  CHECK_EQ(histogram_data.ranges_checksum, histogram_data_ptr->ranges_checksum);
 
   HistogramBase::Sample* ranges_data =
       allocator->GetAsObject<HistogramBase::Sample>(histogram_data.ranges_ref,
                                                     kTypeIdRangesArray);
   if (!ranges_data || histogram_data.bucket_count < 2 ||
       histogram_data.bucket_count + 1 >
           std::numeric_limits<uint32_t>::max() /
               sizeof(HistogramBase::Sample) ||
       allocator->GetAllocSize(histogram_data.ranges_ref) <
           (histogram_data.bucket_count + 1) * sizeof(HistogramBase::Sample)) {
@@ skipping 24 matching lines @@
     NOTREACHED();
     return nullptr;
   }
 
   // After the main "counts" array is a second array using for storing what
   // was previously logged. This is used to calculate the "delta" during
   // snapshot operations.
   HistogramBase::AtomicCount* logged_data =
       counts_data + histogram_data.bucket_count;
 
-  CHECK_LT(0, histogram_data.minimum);
-  CHECK_LT(0, histogram_data.maximum);
   std::string name(histogram_data_ptr->name);
   HistogramBase* histogram = nullptr;
   switch (histogram_data.histogram_type) {
     case HISTOGRAM:
       histogram = Histogram::PersistentGet(
           name,
           histogram_data.minimum,
           histogram_data.maximum,
           ranges,
           counts_data,
@@ skipping 206 matching lines @@
     while (true) {
       HistogramBase* histogram = GetNextPersistentHistogram(g_allocator, &iter);
       if (!histogram)
         break;
       StatisticsRecorder::RegisterOrDeleteDuplicate(histogram);
     }
   }
 }
 
 }  // namespace base