Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup

Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/614d20a64195e64c047432251e3fb3e7b5142425

[Wei Li, 2016-03-15 20:13:03]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-03-15 20:21:21]

Patchset #1 (id:20001) has been deleted

[Wei Li, 2016-03-15 20:27:31]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-03-15 20:27:31]

PTAL, thanks

[Tom Sepez, 2016-03-15 20:42:14]

lgtm

[Wei Li, 2016-03-15 20:55:21]

Description was changed from

==========
Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup
==========

to

==========
Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/614d20a64195e64c047432251e3fb3e7b514...
==========

[Wei Li, 2016-03-15 20:55:22]

Committed patchset #1 (id:40001) manually as
614d20a64195e64c047432251e3fb3e7b5142425 (presubmit successful).

[hashimoto, 2016-03-16 04:29:33]

hashimoto@chromium.org changed reviewers:
+ hashimoto@chromium.org

[hashimoto, 2016-03-16 04:29:34]

https://codereview.chromium.org/1797423002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1797423002/diff/40001/BUILD.gn#newcode1486
BUILD.gn:1486: include_dirs += [
This line results in an error like this:

ERROR at //third_party/pdfium/BUILD.gn:1495:5: Undefined variable for +=.
    include_dirs += [

There should be include_dirs = [] somewhere before this line.

[Wei Li, 2016-03-18 22:34:53]

Patchset #2 (id:60001) has been deleted