Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 250dcfe111c93ef417b3c70e16695ee29ec23a7c..0ada15ce9050f53fb8427dcf51ed9a592e196849 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1479,6 +1479,15 @@ test("pdfium_unittests") {
       "xfa/fxfa/parser/xfa_utils_imp_unittest.cpp",
     ]
   }
+  if (pdf_enable_v8) {
+    sources += [
+      "fpdfsdk/javascript/public_methods_unittest.cpp",
+    ]
+    include_dirs += [

[hashimoto, 2016/03/16 04:29:34]

This line results in an error like this:

ERROR at //third_party/pdfium/BUILD.gn:1495:5: Undefined variable for +=.
    include_dirs += [

There should be include_dirs = [] somewhere before this line.

+      "//v8",
+      "//v8/include",
+    ]
+  }
   configs += [ ":pdfium_config" ]
 }