Fix CJS_PublicMethods::IsNumber() with unit test and some cleanup

BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/v8.gni")
 import("//testing/test.gni")
 import("pdfium.gni")
 
 config("pdfium_config") {
   cflags = []
@@ skipping 1461 matching lines @@
     ":test_support",
     "//testing/gtest",
     "//testing/gtest:gtest_main",
   ]
   if (pdf_enable_xfa) {
     sources += [
       "xfa/fxbarcode/pdf417/BC_PDF417HighLevelEncoder_unittest.cpp",
       "xfa/fxfa/parser/xfa_utils_imp_unittest.cpp",
     ]
   }
+  if (pdf_enable_v8) {
+    sources += [
+      "fpdfsdk/javascript/public_methods_unittest.cpp",
+    ]
+    include_dirs += [

[hashimoto, 2016/03/16 04:29:34]

This line results in an error like this:

ERROR at //third_party/pdfium/BUILD.gn:1495:5: Undefined variable for +=.
    include_dirs += [

There should be include_dirs = [] somewhere before this line.

+      "//v8",
+      "//v8/include",
+    ]
+  }
   configs += [ ":pdfium_config" ]
 }
 
 test("pdfium_embeddertests") {
   sources = [
     "core/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp",
     "core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp",
     "core/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp",
@@ skipping 33 matching lines @@
       "//v8:v8_libplatform",
     ]
     include_dirs += [
       "//v8",
       "//v8/include",
     ]
     configs += [ "//v8:external_startup_data" ]
   }
   configs += [ ":pdfium_config" ]
 }