 Chromium Code Reviews
 Chromium Code Reviews Issue 1797393008:
  PlzNavigate: fix two RenderViewImplTests related to history  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1797393008:
  PlzNavigate: fix two RenderViewImplTests related to history  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/public/test/render_view_test.h | 
| diff --git a/content/public/test/render_view_test.h b/content/public/test/render_view_test.h | 
| index 3c3b3f8c07b2e3dcc530f4cda357956e930bbe25..7fb7653230eb029c6ae463855ca2c7e04f12798d 100644 | 
| --- a/content/public/test/render_view_test.h | 
| +++ b/content/public/test/render_view_test.h | 
| @@ -103,8 +103,8 @@ class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient { | 
| // Navigates the main frame back or forward in session history and commits. | 
| // The caller must capture a PageState for the target page. | 
| - void GoBack(const PageState& state); | 
| - void GoForward(const PageState& state); | 
| + void GoBack(const GURL& url, const PageState& state); | 
| 
sky
2016/03/23 21:33:32
Seems bizarre that goback/forward take a url. Don'
 
Charlie Reis
2016/03/23 21:51:14
I think it's serialized inside the PageState.  I'm
 | 
| + void GoForward(const GURL& url, const PageState& state); | 
| // Sends one native key event over IPC. | 
| void SendNativeKeyEvent(const NativeWebKeyboardEvent& key_event); | 
| @@ -213,7 +213,7 @@ class RenderViewTest : public testing::Test, blink::WebLeakDetectorClient { | 
| #endif | 
| private: | 
| - void GoToOffset(int offset, const PageState& state); | 
| + void GoToOffset(int offset, const GURL& url, const PageState& state); | 
| }; | 
| } // namespace content |