Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1793293003:
[turbofan] Enable TurboFan when compiling JS runtime calls. (Closed)
|
Created:
4 years, 9 months ago by Igor Sheludko Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Enable TurboFan when compiling JS runtime calls.
This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002).
BUG=chromium:592692
LOG=N
Committed: https://crrev.com/bb3cfeefd6ac722490653c380bd5b6df9e33ed4f
Cr-Commit-Position: refs/heads/master@{#34783}
Patch Set 1 #Patch Set 2 : Rebasing #
Depends on Patchset: Messages
Total messages: 28 (16 generated)
Description was changed from ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421. BUG=chromium:592692 LOG=N ========== to ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by crrev/7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ==========
Description was changed from ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by crrev/7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ========== to ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by http://crrev/7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ==========
Description was changed from ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by http://crrev/7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ========== to ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ==========
ishell@chromium.org changed reviewers: + mstarzinger@chromium.org
PTAL and CQ
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793293003/1
LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2872) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793293003/20001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793293003/20001
The CQ bit was unchecked by ishell@chromium.org
The CQ bit was checked by ishell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/1793293003/#ps20001 (title: "Rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793293003/20001
The CQ bit was unchecked by ishell@chromium.org
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793293003/20001
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ========== to ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N ========== to ========== [turbofan] Enable TurboFan when compiling JS runtime calls. This should recover a part of the regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). BUG=chromium:592692 LOG=N Committed: https://crrev.com/bb3cfeefd6ac722490653c380bd5b6df9e33ed4f Cr-Commit-Position: refs/heads/master@{#34783} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bb3cfeefd6ac722490653c380bd5b6df9e33ed4f Cr-Commit-Position: refs/heads/master@{#34783}
Message was sent while issue was closed.
Crankshaft should also support JS runtime calls by now, since there's no magic LoadIC associated with them anymore.
Message was sent while issue was closed.
On 2016/03/15 13:40:00, Benedikt Meurer (Google) wrote: > Crankshaft should also support JS runtime calls by now, since there's no magic > LoadIC associated with them anymore. Indeed, https://codereview.chromium.org/1807913002/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
