Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1798373002: [turbofan] Fix double object allocation when inlining a construct call of a derived class.... (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix double object allocation when inlining a construct call of a derived class or an Api function. Committed: https://crrev.com/2ee59e5e28fd757437d94db84559ace7301e3a50 Cr-Commit-Position: refs/heads/master@{#34780}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/compiler/js-inlining.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1793293003 Patch 20001

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798373002/20001
4 years, 9 months ago (2016-03-15 09:43:28 UTC) #4
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-15 09:52:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798373002/20001
4 years, 9 months ago (2016-03-15 10:07:32 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 10:36:01 UTC) #11
Michael Starzinger
LGTM. Nice catch. Thanks!
4 years, 9 months ago (2016-03-15 10:52:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1798373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1798373002/20001
4 years, 9 months ago (2016-03-15 10:57:44 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-15 10:59:26 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 11:01:16 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2ee59e5e28fd757437d94db84559ace7301e3a50
Cr-Commit-Position: refs/heads/master@{#34780}

Powered by Google App Engine
This is Rietveld 408576698