Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Issue 179293003: Make Tab non-abstract by adding an empty implementation of createAutoLoginProcessor(). (Closed)

Created:
6 years, 9 months ago by Bernhard Bauer
Modified:
6 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Visibility:
Public.

Description

Make Tab non-abstract by adding an empty implementation of createAutoLoginProcessor(). This is a followup to https://codereview.chromium.org/148523013. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Bernhard Bauer
6 years, 9 months ago (2014-03-04 17:07:26 UTC) #1
Bernhard Bauer
Ping?
6 years, 9 months ago (2014-03-05 14:00:01 UTC) #2
Ted C
lgtm!
6 years, 9 months ago (2014-03-05 21:38:28 UTC) #3
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 9 months ago (2014-03-05 22:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/179293003/1
6 years, 9 months ago (2014-03-05 22:41:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 23:04:04 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275701
6 years, 9 months ago (2014-03-05 23:04:05 UTC) #7
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 9 months ago (2014-03-05 23:13:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/179293003/1
6 years, 9 months ago (2014-03-05 23:14:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/179293003/1
6 years, 9 months ago (2014-03-06 00:09:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/179293003/1
6 years, 9 months ago (2014-03-06 02:51:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/179293003/1
6 years, 9 months ago (2014-03-06 03:15:55 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 06:09:32 UTC) #13
Message was sent while issue was closed.
Change committed as 255277

Powered by Google App Engine
This is Rietveld 408576698