[Android] Rename TabBase to Tab

[Android] Rename TabBase to Tab

BUG=339423
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254147

[bulach, 2014-02-27 16:53:05]

lgtm, but certainly Ted has the final word.

looking forward to this!!

[Ted C, 2014-02-27 17:25:43]

lgtm w/ a nit and maybe one cleanup (more likely something to push off to a
follow up)

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:209:
observer.onContextMenuShown(Tab.this, menu);
This should go back on the previous line (braces always required in java unless
it all fits on one line)

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:241: protected
Tab(boolean incognito, Context context, WindowAndroid window) {
any reason to reduce the visibility of the constructors?  I know the hope is
that this would be non-static in the future so maybe it's worth keeping them
public for now.

And to go even further...it looks like createAutoLoginProcessor is the only
method keeping this class still abstract.  Maybe we should just have that return
an empty implementation and remove the abstract for good.

[Bernhard Bauer, 2014-02-27 17:40:03]

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:209:
observer.onContextMenuShown(Tab.this, menu);
On 2014/02/27 17:25:44, Ted C wrote:
> This should go back on the previous line (braces always required in java
unless
> it all fits on one line)

Done.

https://codereview.chromium.org/148523013/diff/160001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:241: protected
Tab(boolean incognito, Context context, WindowAndroid window) {
On 2014/02/27 17:25:44, Ted C wrote:
> any reason to reduce the visibility of the constructors?  I know the hope is
> that this would be non-static in the future so maybe it's worth keeping them
> public for now.

Hm, I think that was an artifact from an older version where I was trying to do
the rename without breaking downstream temporarily (which turned out not to
work). Changed to public again. 

> And to go even further...it looks like createAutoLoginProcessor is the only
> method keeping this class still abstract.  Maybe we should just have that
return
> an empty implementation and remove the abstract for good.

Sounds good; I'll do that in a follow-up CL though, to keep this one focused on
one thing.

[Bernhard Bauer, 2014-02-28 11:07:21]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-02-28 11:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/148523013/180001

[commit-bot: I haz the power, 2014-02-28 11:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 11:07:56]

Failed to apply patch for base/android/jni_generator/jni_generator.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/android/jni_generator/jni_generator.py
  Hunk #1 FAILED at 484.
  Hunk #2 FAILED at 531.
  2 out of 2 hunks FAILED -- saving rejects to file
base/android/jni_generator/jni_generator.py.rej

Patch:       base/android/jni_generator/jni_generator.py
Index: base/android/jni_generator/jni_generator.py
diff --git a/base/android/jni_generator/jni_generator.py
b/base/android/jni_generator/jni_generator.py
index
6b4a5f679672e439b0d0578e19942f415baa7e8c..f5aab86c07f0e38da68ca7083e069a23835f859c
100755
--- a/base/android/jni_generator/jni_generator.py
+++ b/base/android/jni_generator/jni_generator.py
@@ -484,9 +484,13 @@ class JNIFromJavaP(object):
   def __init__(self, contents, options):
     self.contents = contents
     self.namespace = options.namespace
-    self.fully_qualified_class = re.match(
-        '.*?(class|interface) (?P<class_name>.*?)( |{)',
-        contents[1]).group('class_name')
+    for line in contents:
+      class_name = re.match(
+          '.*?(public).*?(class|interface) (?P<class_name>\S+?)( |\Z)',
+          line)
+      if class_name:
+        self.fully_qualified_class = class_name.group('class_name')
+        break
     self.fully_qualified_class = self.fully_qualified_class.replace('.', '/')
     # Java 7's javap includes type parameters in output, like HashSet<T>. Strip
     # away the <...> and use the raw class name that Java 6 would've given us.
@@ -531,14 +535,16 @@ class JNIFromJavaP(object):
     self.called_by_natives = MangleCalledByNatives(self.called_by_natives)
 
     self.constant_fields = []
-    re_constant_field = re.compile('public static final int (?P<name>.*?);')
+    re_constant_field = re.compile('.*?public static final int (?P<name>.*?);')
     re_constant_field_value = re.compile(
-        '.*?Constant value: int (?P<value>(-*[0-9]+)?)')
+        '.*?Constant(Value| value): int (?P<value>(-*[0-9]+)?)')
     for lineno, content in enumerate(contents[2:], 2):
       match = re.match(re_constant_field, content)
       if not match:
         continue
       value = re.match(re_constant_field_value, contents[lineno + 2])
+      if not value:
+        value = re.match(re_constant_field_value, contents[lineno + 3])
       if value:
         self.constant_fields.append(
             ConstantField(name=match.group('name'),

[Bernhard Bauer, 2014-02-28 11:12:12]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-02-28 11:12:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/148523013/200001

[commit-bot: I haz the power, 2014-02-28 16:23:56]

Change committed as 254147