Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 179293003: Make Tab non-abstract by adding an empty implementation of createAutoLoginProcessor(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index e58736e6f25418d37e4d4e020a51b462877f8b0d..0980916cd51fde273961ad169ac9fdbe0cdbe662 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -53,7 +53,7 @@ import java.util.concurrent.atomic.AtomicInteger;
* their own native pointer reference, but Tab#destroy() will handle deleting the native
* object.
*/
-public abstract class Tab implements NavigationClient {
+public class Tab implements NavigationClient {
public static final int INVALID_TAB_ID = -1;
/** Used for automatically generating tab ids. */
@@ -392,7 +392,14 @@ public abstract class Tab implements NavigationClient {
* Create an {@code AutoLoginProcessor} to decide how to handle login
* requests.
*/
- protected abstract AutoLoginProcessor createAutoLoginProcessor();
+ protected AutoLoginProcessor createAutoLoginProcessor() {
+ return new AutoLoginProcessor() {
+ @Override
+ public void processAutoLoginResult(String accountName, String authToken,
+ boolean success, String result) {
+ }
+ };
+ }
/**
* Prints the current page.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698