Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp

Issue 1791543005: InPrePaint document state and PrePaintTreeWalk class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp b/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
index 5e9e11c7bdf9c8dbfd5f116d04963ba18d66f48c..6f912483be1ef14cc33df73d7cc9177dd243e3ef 100644
--- a/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp
@@ -210,17 +210,17 @@ bool DocumentLifecycle::canAdvanceTo(LifecycleState nextState) const
if (nextState == InCompositingUpdate)
return true;
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
- if (nextState == InUpdatePaintProperties)
+ if (nextState == InPrePaintTreeWalk)
return true;
} else if (nextState == InPaint) {
return true;
}
break;
- case InUpdatePaintProperties:
- if (nextState == UpdatePaintPropertiesClean && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ case InPrePaintTreeWalk:
+ if (nextState == PrePaintTreeWalkClean && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
return true;
break;
- case UpdatePaintPropertiesClean:
+ case PrePaintTreeWalkClean:
pdr. 2016/03/12 04:04:24 Nit: PrePaintTreeWalkFinished or PrePaintTreeWalkC
Xianzhu 2016/03/14 18:56:04 I removed "TreeWalk" from the new state names. How
if (nextState == InPaint && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
return true;
break;
@@ -308,8 +308,8 @@ const char* DocumentLifecycle::stateAsDebugString(const LifecycleState state)
DEBUG_STRING_CASE(CompositingClean);
DEBUG_STRING_CASE(InPaintInvalidation);
DEBUG_STRING_CASE(PaintInvalidationClean);
- DEBUG_STRING_CASE(InUpdatePaintProperties);
- DEBUG_STRING_CASE(UpdatePaintPropertiesClean);
+ DEBUG_STRING_CASE(InPrePaintTreeWalk);
+ DEBUG_STRING_CASE(PrePaintTreeWalkClean);
DEBUG_STRING_CASE(InPaint);
DEBUG_STRING_CASE(PaintClean);
DEBUG_STRING_CASE(Stopping);

Powered by Google App Engine
This is Rietveld 408576698