Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1791543005: InPrePaint document state and PrePaintTreeWalk class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index dcf1ef2549f2e3d4ac5458ef4ba2ddfa5e469c4b..1ef7c8e19058b9b270810b15d722596f6a361148 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -81,7 +81,7 @@
#include "core/page/scrolling/ScrollingCoordinator.h"
#include "core/paint/FramePainter.h"
#include "core/paint/PaintLayer.h"
-#include "core/paint/PaintPropertyTreeBuilder.h"
+#include "core/paint/PrePaintTreeWalk.h"
#include "core/plugins/PluginView.h"
#include "core/style/ComputedStyle.h"
#include "core/svg/SVGDocumentExtensions.h"
@@ -2396,7 +2396,7 @@ void FrameView::updateLifecycleToLayoutClean()
void FrameView::scheduleVisualUpdateForPaintInvalidationIfNeeded()
{
LocalFrame* localFrameRoot = frame().localFrameRoot();
- if (!localFrameRoot->view()->m_isUpdatingAllLifecyclePhases || lifecycle().state() >= DocumentLifecycle::PaintInvalidationClean) {
+ if (!localFrameRoot->view()->m_isUpdatingAllLifecyclePhases || lifecycle().state() >= DocumentLifecycle::PrePaintTreeWalkClean) {
// Schedule visual update to process the paint invalidation in the next cycle.
localFrameRoot->scheduleVisualUpdateUnlessThrottled();
}
@@ -2479,9 +2479,9 @@ void FrameView::updatePaintProperties()
ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
- forAllNonThrottledFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::InUpdatePaintProperties); });
- PaintPropertyTreeBuilder().buildPropertyTrees(*this);
- forAllNonThrottledFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::UpdatePaintPropertiesClean); });
+ forAllNonThrottledFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::InPrePaintTreeWalk); });
+ PrePaintTreeWalk().buildPropertyTrees(*this);
+ forAllNonThrottledFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::PrePaintTreeWalkClean); });
}
void FrameView::synchronizedPaint()

Powered by Google App Engine
This is Rietveld 408576698