InPrePaint document state and PrePaintTreeWalk class

third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 192 matching lines @@
     case InPaintInvalidation:
         return nextState == PaintInvalidationClean;
     case PaintInvalidationClean:
         if (nextState == InStyleRecalc)
             return true;
         if (nextState == InPreLayout)
             return true;
         if (nextState == InCompositingUpdate)
             return true;
         if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
-            if (nextState == InUpdatePaintProperties)
+            if (nextState == InPrePaintTreeWalk)
                 return true;
         } else if (nextState == InPaint) {
             return true;
         }
         break;
-    case InUpdatePaintProperties:
-        if (nextState == UpdatePaintPropertiesClean && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    case InPrePaintTreeWalk:
+        if (nextState == PrePaintTreeWalkClean && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
             return true;
         break;
-    case UpdatePaintPropertiesClean:
+    case PrePaintTreeWalkClean:

[pdr., 2016/03/12 04:04:24]

Nit: PrePaintTreeWalkFinished or PrePaintTreeWalkComplete?

[Xianzhu, 2016/03/14 18:56:04]

I removed "TreeWalk" from the new state names. How about "PrePaintClean"?

         if (nextState == InPaint && RuntimeEnabledFeatures::slimmingPaintV2Enabled())
             return true;
         break;
     case InPaint:
         if (nextState == PaintClean)
             return true;
         break;
     case PaintClean:
         if (nextState == InStyleRecalc)
             return true;
@@ skipping 67 matching lines @@
         DEBUG_STRING_CASE(InLayoutSubtreeChange);
         DEBUG_STRING_CASE(LayoutSubtreeChangeClean);
         DEBUG_STRING_CASE(InPreLayout);
         DEBUG_STRING_CASE(InPerformLayout);
         DEBUG_STRING_CASE(AfterPerformLayout);
         DEBUG_STRING_CASE(LayoutClean);
         DEBUG_STRING_CASE(InCompositingUpdate);
         DEBUG_STRING_CASE(CompositingClean);
         DEBUG_STRING_CASE(InPaintInvalidation);
         DEBUG_STRING_CASE(PaintInvalidationClean);
-        DEBUG_STRING_CASE(InUpdatePaintProperties);
-        DEBUG_STRING_CASE(UpdatePaintPropertiesClean);
+        DEBUG_STRING_CASE(InPrePaintTreeWalk);
+        DEBUG_STRING_CASE(PrePaintTreeWalkClean);
         DEBUG_STRING_CASE(InPaint);
         DEBUG_STRING_CASE(PaintClean);
         DEBUG_STRING_CASE(Stopping);
         DEBUG_STRING_CASE(Stopped);
         DEBUG_STRING_CASE(Disposed);
     }
 
     ASSERT_NOT_REACHED();
     return "Unknown";
 }
 #endif
 
 } // namespace blink