Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(189)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
179027
: Make a bunch of backlogged breaking changes to the extensions (Closed)
Created:
11 years, 3 months ago by
Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Erik does not do reviews
,
rafaelw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.
Description
Make a bunch of backlogged breaking changes to the extensions API in prep for dev: * Enforce permissions on cross-origin XHR * Enforce module-level permissions * Decided not to completely remove chrome.self since it is so widely used, but removed all references to it from samples and docs. BUG=
16356
,
12129
,
12140
TEST=Sample extensions on
http://dev.chromium.org/developers/design-documents/extensions/samples
should still work Committed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24816
Patch Set 1
#
Patch Set 2 : Put chrome.self back
#
Created:
11 years, 3 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+15 lines, -45 lines
)
Patch
M
chrome/browser/extensions/extension_messages_unittest.cc
View
3 chunks
+3 lines, -3 lines
0 comments
Download
M
chrome/common/extensions/docs/static/background_pages.html
View
2 chunks
+2 lines, -2 lines
0 comments
Download
M
chrome/renderer/extensions/extension_process_bindings.cc
View
3 chunks
+1 line, -27 lines
0 comments
Download
M
chrome/renderer/render_view.cc
View
1 chunk
+1 line, -5 lines
0 comments
Download
M
chrome/renderer/renderer_resources.grd
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/benchmark/toolstrip.html
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/getviews/common.js
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/password_maker/toolstrip.html
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/screenshot/screenshot.js
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/subscribe/toolstrip.html
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/samples/subscribe_page_action/background.html
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/test/data/extensions/uitest/event_sink/test.html
View
1 chunk
+1 line, -1 line
0 comments
Download
Messages
Total messages: 3 (0 generated)
Expand Messages
|
Collapse Messages
Aaron Boodman
11 years, 3 months ago (2009-08-28 20:53:35 UTC)
#1
Aaron Boodman
11 years, 3 months ago (2009-08-28 20:57:59 UTC)
#2
rafaelw
lgtm
11 years, 3 months ago (2009-08-28 21:20:03 UTC)
#3
lgtm
Expand Messages
|
Collapse Messages
Issue 179027: Make a bunch of backlogged breaking changes to the extensions (Closed)
Created 11 years, 3 months ago by Aaron Boodman
Modified 9 years, 6 months ago
Reviewers: Erik does not do reviews, rafaelw
Base URL:
Comments: 0
This is Rietveld
408576698