Make a bunch of backlogged breaking changes to the extensions

chrome/renderer/extensions/extension_process_bindings.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/extension_process_bindings.h"
 
 #include "base/singleton.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "chrome/common/render_messages.h"
@@ skipping 232 matching lines @@
         !args[2]->IsInt32() || !args[3]->IsBoolean())
       return v8::Undefined();
 
     std::string name = *v8::String::AsciiValue(args[0]);
     if (GetFunctionNameSet()->find(name) == GetFunctionNameSet()->end()) {
       NOTREACHED() << "Unexpected function " << name;
       return v8::Undefined();
     }
 
     if (!ExtensionProcessBindings::CurrentContextHasPermission(name)) {
-#if EXTENSION_TIME_TO_BREAK_API
       return ExtensionProcessBindings::ThrowPermissionDeniedException(name);
-#else
-      ExtensionProcessBindings::ThrowPermissionDeniedException(name);
-#endif
     }
 
     std::string json_args = *v8::String::Utf8Value(args[1]);
     int request_id = args[2]->Int32Value();
     bool has_callback = args[3]->BooleanValue();
 
     v8::Persistent<v8::Context> current_context =
         v8::Persistent<v8::Context>::New(v8::Context::GetCurrent());
     DCHECK(!current_context.IsEmpty());
     GetPendingRequestMap()[request_id].reset(new PendingRequest(
@@ skipping 98 matching lines @@
 
 // static
 bool ExtensionProcessBindings::CurrentContextHasPermission(
     const std::string& function_name) {
   std::string extension_id = ExtensionImpl::ExtensionIdForCurrentContext();
   PermissionsMap& permissions_map = *GetPermissionsMap(extension_id);
   std::string permission_name = GetPermissionName(function_name);
   PermissionsMap::iterator it = permissions_map.find(permission_name);
 
   // We explicitly check if the permission entry is present and false, because
-  // some APIs do not have a required permission entry (ie, "chrome.self").
+  // some APIs do not have a required permission entry (ie, "chrome.extension").
   return (it == permissions_map.end() || it->second);
 }
 
 // static
 v8::Handle<v8::Value>
     ExtensionProcessBindings::ThrowPermissionDeniedException(
       const std::string& function_name) {
   static const char kMessage[] =
       "You do not have permission to use 'chrome.%s'. Be sure to declare"
       " in your manifest what permissions you need.";
   std::string permission_name = GetPermissionName(function_name);
   std::string error_msg = StringPrintf(kMessage, permission_name.c_str());
 
-#if EXTENSION_TIME_TO_BREAK_API
   return v8::ThrowException(v8::Exception::Error(
       v8::String::New(error_msg.c_str())));
-#else
-  // Call console.error for now.
-
-  v8::HandleScope scope;
-
-  v8::Local<v8::Value> console =
-      v8::Context::GetCurrent()->Global()->Get(v8::String::New("console"));
-  v8::Local<v8::Value> console_error;
-  if (!console.IsEmpty() && console->IsObject())
-    console_error = console->ToObject()->Get(v8::String::New("error"));
-  if (console_error.IsEmpty() || !console_error->IsFunction())
-    return v8::Undefined();
-
-  v8::Local<v8::Function> function =
-      v8::Local<v8::Function>::Cast(console_error);
-  v8::Local<v8::Value> argv[] = { v8::String::New(error_msg.c_str()) };
-  if (!function.IsEmpty())
-    function->Call(console->ToObject(), arraysize(argv), argv);
-
-  return v8::Undefined();
-#endif
 }