chrome/test/data/extensions/samples/subscribe/toolstrip.html - Issue 179027: Make a bunch of backlogged breaking changes to the extensions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/samples/subscribe/toolstrip.html

Issue 179027: Make a bunch of backlogged breaking changes to the extensions (Closed)

Patch Set: Put chrome.self back Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/extensions/samples/screenshot/screenshot.js ('k') | chrome/test/data/extensions/samples/subscribe_page_action/background.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <div id="button" class="toolstrip-button">	2 <div id="button" class="toolstrip-button">

3 <img id="icon" src="icon_disabled.png"><span>Subscribe</span>	3 <img id="icon" src="icon_disabled.png"><span>Subscribe</span>

4 </div>	4 </div>

5	5

6 <script>	6 <script>

7 var icon = document.getElementById("icon");	7 var icon = document.getElementById("icon");

8 var button = document.getElementById("button");	8 var button = document.getElementById("button");

9 var enabled = false;	9 var enabled = false;

10 var feedUrl, req;	10 var feedUrl, req;

11	11

12 button.onclick = handleClick;	12 button.onclick = handleClick;

13	13

14 chrome.self.onConnect.addListener(function(port) {	14 chrome.extension.onConnect.addListener(function(port) {

15 port.onMessage.addListener(function(feedUrls) {	15 port.onMessage.addListener(function(feedUrls) {

16 // TODO(aa): When we have the ability to display drop downs, we should let	16 // TODO(aa): When we have the ability to display drop downs, we should let

17 // the user pick which feed to subscribe. Right now, we just pick the	17 // the user pick which feed to subscribe. Right now, we just pick the

18 // first.	18 // first.

19 feedUrl = feedUrls[0];	19 feedUrl = feedUrls[0];

20 if (!feedUrl) {	20 if (!feedUrl) {

21 icon.src = "icon_disabled.png";	21 icon.src = "icon_disabled.png";

22 enabled = false;	22 enabled = false;

23 } else {	23 } else {

24 icon.src = "icon.png";	24 icon.src = "icon.png";

(...skipping 18 matching lines...) Expand all Loading...
43 }	43 }

44	44

45 function handleClick() {	45 function handleClick() {

46 if (enabled) {	46 if (enabled) {

47 var url = "http://www.google.com/reader/view/feed/" + feedUrl;	47 var url = "http://www.google.com/reader/view/feed/" + feedUrl;

48 chrome.tabs.create({url: url});	48 chrome.tabs.create({url: url});

49 }	49 }

50 }	50 }

51 </script>	51 </script>

52 </html>	52 </html>

OLD	NEW