Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1789543003: MD Settings: move AdvancedOptionsUtilities to a settings-accessible place (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: move AdvancedOptionsUtilities to a settings-accessible place Also, move from class + static methods to simply namespaced methods. Doesn't make much sense to have a static only class with more code and longer identifiers, but I could be convinced if there's a reason. R=dpapad@chromium.org BUG=546844 Committed: https://crrev.com/71382ce7fc4861fcddc6e261438a2cf6e70d919d Cr-Commit-Position: refs/heads/master@{#380765}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -404 lines) Patch
D chrome/browser/ui/webui/options/advanced_options_utils.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_linux.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_mac.mm View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.cc View 2 chunks +9 lines, -2 lines 0 comments Download
A chrome/browser/ui/webui/settings_utils.h View 1 chunk +24 lines, -0 lines 2 comments Download
A + chrome/browser/ui/webui/settings_utils_linux.cc View 4 chunks +6 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/settings_utils_mac.mm View 3 chunks +6 lines, -10 lines 0 comments Download
A + chrome/browser/ui/webui/settings_utils_win.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Dan Beam
https://codereview.chromium.org/1789543003/diff/1/chrome/browser/ui/webui/settings_utils.h File chrome/browser/ui/webui/settings_utils.h (right): https://codereview.chromium.org/1789543003/diff/1/chrome/browser/ui/webui/settings_utils.h#newcode20 chrome/browser/ui/webui/settings_utils.h:20: void ShowManageSSLCertificates(content::WebContents* web_contents); this is why i sent to ...
4 years, 9 months ago (2016-03-11 20:28:57 UTC) #1
dpapad
LGTM https://codereview.chromium.org/1789543003/diff/1/chrome/browser/ui/webui/settings_utils.h File chrome/browser/ui/webui/settings_utils.h (right): https://codereview.chromium.org/1789543003/diff/1/chrome/browser/ui/webui/settings_utils.h#newcode20 chrome/browser/ui/webui/settings_utils.h:20: void ShowManageSSLCertificates(content::WebContents* web_contents); On 2016/03/11 at 20:28:56, Dan ...
4 years, 9 months ago (2016-03-11 21:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789543003/1
4 years, 9 months ago (2016-03-11 21:55:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 22:42:38 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:43:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71382ce7fc4861fcddc6e261438a2cf6e70d919d
Cr-Commit-Position: refs/heads/master@{#380765}

Powered by Google App Engine
This is Rietveld 408576698