Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2185)

Unified Diff: chrome/browser/ui/webui/settings/system_handler.cc

Issue 1789543003: MD Settings: move AdvancedOptionsUtilities to a settings-accessible place (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/system_handler.cc
diff --git a/chrome/browser/ui/webui/settings/system_handler.cc b/chrome/browser/ui/webui/settings/system_handler.cc
index c7d926911e5e677efd843bac6b43cbd0e1c276a2..49835c5dc4da15111ff55db243a816f09cbcd219 100644
--- a/chrome/browser/ui/webui/settings/system_handler.cc
+++ b/chrome/browser/ui/webui/settings/system_handler.cc
@@ -10,6 +10,10 @@
#include "base/metrics/user_metrics_action.h"
#include "content/public/browser/web_ui.h"
+#if !defined(OS_CHROMEOS)
+#include "chrome/browser/ui/webui/settings_utils.h"
+#endif
+
namespace settings {
SystemHandler::SystemHandler() {}
@@ -24,8 +28,11 @@ void SystemHandler::RegisterMessages() {
void SystemHandler::HandleChangeProxySettings(const base::ListValue* /*args*/) {
base::RecordAction(base::UserMetricsAction("Options_ShowProxySettings"));
- // TODO(dbeam): port AdvancedOptionsUtilities::ShowNetworkProxySettings from
- // advanced_options_utils.h to new, settings accessible place.
+#if defined(OS_CHROMEOS)
+ NOTREACHED();
+#else
+ settings_utils::ShowNetworkProxySettings(web_ui()->GetWebContents());
+#endif
}
} // namespace settings

Powered by Google App Engine
This is Rietveld 408576698