Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784353004: MD Settings: make "CHANGE PROXY SETTINGS" button primary styled (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-utils
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make "CHANGE PROXY SETTINGS" button primary styled R=dschuyler@chromium.org BUG=546844 NOTRY=true Committed: https://crrev.com/1eb88a42af1570cfc4b00ad2a41d9e8abfec1ef0 Cr-Commit-Position: refs/heads/master@{#380769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/system_page/system_page.html View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1789543003 Patch 1

Messages

Total messages: 10 (4 generated)
Dan Beam
4 years, 9 months ago (2016-03-11 22:38:19 UTC) #1
Dan Beam
before: http://i.imgur.com/KHnvw3i.png after: http://i.imgur.com/UraHyCb.png
4 years, 9 months ago (2016-03-11 22:40:47 UTC) #2
dschuyler
lgtm
4 years, 9 months ago (2016-03-11 22:45:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784353004/1
4 years, 9 months ago (2016-03-11 22:47:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 22:53:45 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:54:43 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1eb88a42af1570cfc4b00ad2a41d9e8abfec1ef0
Cr-Commit-Position: refs/heads/master@{#380769}

Powered by Google App Engine
This is Rietveld 408576698