Apply the bad flags infobar to some more security-relevant flags

Apply the bad flags infobar to some more security-relevant flags

BUG=343921
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255314

[felt, 2014-02-28 20:58:58]

Hi Peter, can you please review?

[Peter Kasting, 2014-02-28 21:33:50]

LGTM; the ordering and the presence and quality of comments here seem pretty
random.  It would be nice if somehow this list was more readable and regular.  I
don't have advice on how to make that happen.

[felt, 2014-02-28 23:16:02]

I re-grouped them and added comments that are hopefully more meaningful.

[Peter Kasting, 2014-02-28 23:18:22]

On 2014/02/28 23:16:02, felt wrote:
> I re-grouped them and added comments that are hopefully more meaningful.

Awesome, that helps.

[felt, 2014-02-28 23:18:58]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:19:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/60001

[commit-bot: I haz the power, 2014-02-28 23:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:19:50]

Failed to apply patch for chrome/browser/ui/startup/bad_flags_prompt.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/startup/bad_flags_prompt.cc
  Hunk #1 FAILED at 12.
  Hunk #2 succeeded at 34 (offset 7 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/startup/bad_flags_prompt.cc.rej

Patch:       chrome/browser/ui/startup/bad_flags_prompt.cc
Index: chrome/browser/ui/startup/bad_flags_prompt.cc
diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc
b/chrome/browser/ui/startup/bad_flags_prompt.cc
index
a3333e7ca28e2ce7030eb7dafd5e70c279260678..8a49c3f01ea4a92bc53e2751f80582af254b4681
100644
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
@@ -12,7 +12,9 @@
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/translate/core/common/translate_switches.h"
+#include "content/public/common/content_switches.h"
 #include "extensions/common/switches.h"
+#include "google_apis/gaia/gaia_switches.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ -27,21 +29,35 @@ void ShowBadFlagsPrompt(Browser* browser) {
   // Unsupported flags for which to display a warning that "stability and
   // security will suffer".
   static const char* kBadFlags[] = {
-    // These imply disabling the sandbox.
-    switches::kSingleProcess,
-    switches::kNoSandbox,
+    // These flags disable sandbox-related security.
+    switches::kDisableGpuSandbox,
+    switches::kDisableSeccompFilterSandbox,
+    switches::kDisableSetuidSandbox,
     switches::kDisableWebSecurity,
-    // Browser plugin is dangerous on regular pages because it breaks the Same
-    // Origin Policy.
+    switches::kNoSandbox,
+    switches::kSingleProcess,
+
+    // These flags disable or undermine the Same Origin Policy.
     switches::kEnableBrowserPluginForAllViewTypes,
-    extensions::switches::kExtensionsOnChromeURLs,
-    // This parameter should be used only for server side developments.
-    translate::switches::kTranslateScriptURL,
+    switches::kTrustedSpdyProxy,
     translate::switches::kTranslateSecurityOrigin,
+
+    // These flags undermine HTTPS / connection security.
+    switches::kDisableUserMediaSecurity,
   #if defined(ENABLE_WEBRTC)
-    // This flag disables security of media packets in WebRTC.
     switches::kDisableWebRtcEncryption,
   #endif
+    switches::kIgnoreCertificateErrors,
+    switches::kReduceSecurityForTesting,
+    switches::kSyncAllowInsecureXmppConnection,
+
+    // These flags change the URLs that handle PII.
+    autofill::switches::kWalletSecureServiceUrl,
+    switches::kGaiaUrl,
+    translate::switches::kTranslateScriptURL,
+
+    // This flag gives extensions more powers.
+    extensions::switches::kExtensionsOnChromeURLs,
     NULL
   };

[felt, 2014-02-28 23:26:16]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:27:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/80001

[commit-bot: I haz the power, 2014-03-01 01:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/80001

[commit-bot: I haz the power, 2014-03-01 01:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 01:16:33]

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg

[felt, 2014-03-06 00:57:15]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:58:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/80001

[commit-bot: I haz the power, 2014-03-06 02:53:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/80001

[commit-bot: I haz the power, 2014-03-06 03:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/178803004/80001

[commit-bot: I haz the power, 2014-03-06 11:40:05]

Change committed as 255314