Apply the bad flags infobar to some more security-relevant flags

chrome/browser/ui/startup/bad_flags_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/bad_flags_prompt.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/infobars/simple_alert_infobar_delegate.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/simple_message_box.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/switch_utils.h"
 #include "components/startup_metric_utils/startup_metric_utils.h"
 #include "components/translate/core/common/translate_switches.h"
+#include "content/public/common/content_switches.h"
 #include "extensions/common/switches.h"
+#include "google_apis/gaia/gaia_switches.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace chrome {
 
 void ShowBadFlagsPrompt(Browser* browser) {
   content::WebContents* web_contents =
       browser->tab_strip_model()->GetActiveWebContents();
   if (!web_contents)
     return;
 
   // Unsupported flags for which to display a warning that "stability and
   // security will suffer".
   static const char* kBadFlags[] = {
-    // These imply disabling the sandbox.
+    // These flags disable sandbox-related security.
+    switches::kDisableGpuSandbox,
+    switches::kDisableSeccompFilterSandbox,
+    switches::kDisableSetuidSandbox,
+    switches::kDisableWebSecurity,
+    switches::kNoSandbox,
     switches::kSingleProcess,
-    switches::kNoSandbox,
-    switches::kDisableWebSecurity,
-    // Browser plugin is dangerous on regular pages because it breaks the Same
-    // Origin Policy.
+
+    // These flags disable or undermine the Same Origin Policy.
     switches::kEnableBrowserPluginForAllViewTypes,
-    extensions::switches::kExtensionsOnChromeURLs,
-    // This parameter should be used only for server side developments.
-    translate::switches::kTranslateScriptURL,
+    switches::kTrustedSpdyProxy,
     translate::switches::kTranslateSecurityOrigin,
+
+    // These flags undermine HTTPS / connection security.
+    switches::kDisableUserMediaSecurity,
   #if defined(ENABLE_WEBRTC)
-    // This flag disables security of media packets in WebRTC.
     switches::kDisableWebRtcEncryption,
   #endif
+    switches::kIgnoreCertificateErrors,
+    switches::kReduceSecurityForTesting,
+    switches::kSyncAllowInsecureXmppConnection,
+
+    // These flags change the URLs that handle PII.
+    autofill::switches::kWalletSecureServiceUrl,
+    switches::kGaiaUrl,
+    translate::switches::kTranslateScriptURL,
+
+    // This flag gives extensions more powers.
+    extensions::switches::kExtensionsOnChromeURLs,
     NULL
   };
 
   for (const char** flag = kBadFlags; *flag; ++flag) {
     if (CommandLine::ForCurrentProcess()->HasSwitch(*flag)) {
       SimpleAlertInfoBarDelegate::Create(
           InfoBarService::FromWebContents(web_contents),
           InfoBarDelegate::kNoIconID,
           l10n_util::GetStringFUTF16(IDS_BAD_FLAGS_WARNING_MESSAGE,
                                      base::UTF8ToUTF16(
@@ skipping 29 matching lines @@
                                  user_data_dir.LossyDisplayName());
 
   if (cleanup_resource_bundle)
     ResourceBundle::CleanupSharedInstance();
 
   // More complex dialogs cannot be shown before the earliest calls here.
   ShowMessageBox(NULL, title, message, chrome::MESSAGE_BOX_TYPE_WARNING);
 }
 
 }  // namespace chrome