Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5564)

Unified Diff: chrome/browser/ui/startup/bad_flags_prompt.cc

Issue 178803004: Apply the bad flags infobar to some more security-relevant flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/bad_flags_prompt.cc
diff --git a/chrome/browser/ui/startup/bad_flags_prompt.cc b/chrome/browser/ui/startup/bad_flags_prompt.cc
index 3614113034cc3ec939de959baca57f3edc5367cf..5779c99d263862c1b8176a1569ce014bc5c90c3e 100644
--- a/chrome/browser/ui/startup/bad_flags_prompt.cc
+++ b/chrome/browser/ui/startup/bad_flags_prompt.cc
@@ -17,7 +17,9 @@
#include "chrome/common/switch_utils.h"
#include "components/startup_metric_utils/startup_metric_utils.h"
#include "components/translate/core/common/translate_switches.h"
+#include "content/public/common/content_switches.h"
#include "extensions/common/switches.h"
+#include "google_apis/gaia/gaia_switches.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -34,21 +36,35 @@ void ShowBadFlagsPrompt(Browser* browser) {
// Unsupported flags for which to display a warning that "stability and
// security will suffer".
static const char* kBadFlags[] = {
- // These imply disabling the sandbox.
- switches::kSingleProcess,
- switches::kNoSandbox,
+ // These flags disable sandbox-related security.
+ switches::kDisableGpuSandbox,
+ switches::kDisableSeccompFilterSandbox,
+ switches::kDisableSetuidSandbox,
switches::kDisableWebSecurity,
- // Browser plugin is dangerous on regular pages because it breaks the Same
- // Origin Policy.
+ switches::kNoSandbox,
+ switches::kSingleProcess,
+
+ // These flags disable or undermine the Same Origin Policy.
switches::kEnableBrowserPluginForAllViewTypes,
- extensions::switches::kExtensionsOnChromeURLs,
- // This parameter should be used only for server side developments.
- translate::switches::kTranslateScriptURL,
+ switches::kTrustedSpdyProxy,
translate::switches::kTranslateSecurityOrigin,
+
+ // These flags undermine HTTPS / connection security.
+ switches::kDisableUserMediaSecurity,
#if defined(ENABLE_WEBRTC)
- // This flag disables security of media packets in WebRTC.
switches::kDisableWebRtcEncryption,
#endif
+ switches::kIgnoreCertificateErrors,
+ switches::kReduceSecurityForTesting,
+ switches::kSyncAllowInsecureXmppConnection,
+
+ // These flags change the URLs that handle PII.
+ autofill::switches::kWalletSecureServiceUrl,
+ switches::kGaiaUrl,
+ translate::switches::kTranslateScriptURL,
+
+ // This flag gives extensions more powers.
+ extensions::switches::kExtensionsOnChromeURLs,
NULL
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698