Clear page-defined constraints when viewportEnabled setting becomes false.

Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821
Committed: https://crrev.com/c2c57c405548a45113c00b198afa74dcacc982a2
Cr-Commit-Position: refs/heads/master@{#380888}

[skobes, 2016-03-12 00:04:18]

Patchset #1 (id:1) has been deleted

[skobes, 2016-03-12 00:17:00]

Description was changed from

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233
==========

to

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821
==========

[skobes, 2016-03-12 00:57:12]

skobes@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2016-03-12 06:36:08]

Nice!

LGTM (with or without fixing nit)

https://codereview.chromium.org/1787913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebViewImpl.h (right):

https://codereview.chromium.org/1787913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebViewImpl.h:279: // WebViewImpl
Nit: this comment seems to just get cargoculted around. I don't think it means
anything--can you remove it?

[skobes, 2016-03-13 00:34:50]

https://codereview.chromium.org/1787913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebViewImpl.h (right):

https://codereview.chromium.org/1787913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebViewImpl.h:279: // WebViewImpl
On 2016/03/12 06:36:08, pdr wrote:
> Nit: this comment seems to just get cargoculted around. I don't think it means
> anything--can you remove it?

Done.

[skobes, 2016-03-13 00:35:09]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-03-13 00:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1787913002/#ps40001
(title: "address nit")

[commit-bot: I haz the power, 2016-03-13 00:35:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787913002/40001

[commit-bot: I haz the power, 2016-03-13 02:09:52]

Description was changed from

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821
==========

to

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821
==========

[commit-bot: I haz the power, 2016-03-13 02:09:53]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-13 02:11:03]

Description was changed from

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821
==========

to

==========
Clear page-defined constraints when viewportEnabled setting becomes false.

Without this, the values in PageScaleConstraintsSet (and things derived from it
such as the main frame layout size) remain stale after the setting flip.

Dev tools emulation avoided this issue by calling WebViewImpl::disableViewport,
but the layout test runner uses auto-generated code to clear the viewportEnabled
setting (InternalSettingsGenerated::resetToConsistentState).

With this change, DevToolsEmulator can also tweak the setting directly.

BUG=571233, 591821

Committed: https://crrev.com/c2c57c405548a45113c00b198afa74dcacc982a2
Cr-Commit-Position: refs/heads/master@{#380888}
==========

[commit-bot: I haz the power, 2016-03-13 02:11:04]

Patchset 2 (id:??) landed as
https://crrev.com/c2c57c405548a45113c00b198afa74dcacc982a2
Cr-Commit-Position: refs/heads/master@{#380888}