Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: third_party/WebKit/Source/web/DevToolsEmulator.cpp

Issue 1787913002: Clear page-defined constraints when viewportEnabled setting becomes false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/DevToolsEmulator.h" 5 #include "web/DevToolsEmulator.h"
6 6
7 #include "core/frame/FrameHost.h" 7 #include "core/frame/FrameHost.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/frame/Settings.h" 9 #include "core/frame/Settings.h"
10 #include "core/page/Page.h" 10 #include "core/page/Page.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 return; 258 return;
259 m_emulateMobileEnabled = true; 259 m_emulateMobileEnabled = true;
260 m_isOverlayScrollbarsEnabled = RuntimeEnabledFeatures::overlayScrollbarsEnab led(); 260 m_isOverlayScrollbarsEnabled = RuntimeEnabledFeatures::overlayScrollbarsEnab led();
261 RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(true); 261 RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(true);
262 m_isOrientationEventEnabled = RuntimeEnabledFeatures::orientationEventEnable d(); 262 m_isOrientationEventEnabled = RuntimeEnabledFeatures::orientationEventEnable d();
263 RuntimeEnabledFeatures::setOrientationEventEnabled(true); 263 RuntimeEnabledFeatures::setOrientationEventEnabled(true);
264 m_isMobileLayoutThemeEnabled = RuntimeEnabledFeatures::mobileLayoutThemeEnab led(); 264 m_isMobileLayoutThemeEnabled = RuntimeEnabledFeatures::mobileLayoutThemeEnab led();
265 RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(true); 265 RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(true);
266 ComputedStyle::invalidateInitialStyle(); 266 ComputedStyle::invalidateInitialStyle();
267 m_webViewImpl->page()->settings().setUseMobileViewportStyle(true); 267 m_webViewImpl->page()->settings().setUseMobileViewportStyle(true);
268 m_webViewImpl->enableViewport(); 268 m_webViewImpl->page()->settings().setViewportEnabled(true);
269 m_webViewImpl->settings()->setViewportMetaEnabled(true); 269 m_webViewImpl->page()->settings().setViewportMetaEnabled(true);
270 m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars(); 270 m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
271 m_webViewImpl->settings()->setShrinksViewportContentToFit(true); 271 m_webViewImpl->settings()->setShrinksViewportContentToFit(true);
272 m_webViewImpl->page()->settings().setTextAutosizingEnabled(true); 272 m_webViewImpl->page()->settings().setTextAutosizingEnabled(true);
273 m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(true) ; 273 m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(true) ;
274 m_webViewImpl->page()->settings().setPluginsEnabled(false); 274 m_webViewImpl->page()->settings().setPluginsEnabled(false);
275 m_webViewImpl->page()->settings().setAvailablePointerTypes(PointerTypeCoarse ); 275 m_webViewImpl->page()->settings().setAvailablePointerTypes(PointerTypeCoarse );
276 m_webViewImpl->page()->settings().setPrimaryPointerType(PointerTypeCoarse); 276 m_webViewImpl->page()->settings().setPrimaryPointerType(PointerTypeCoarse);
277 m_webViewImpl->page()->settings().setAvailableHoverTypes(HoverTypeOnDemand); 277 m_webViewImpl->page()->settings().setAvailableHoverTypes(HoverTypeOnDemand);
278 m_webViewImpl->page()->settings().setPrimaryHoverType(HoverTypeOnDemand); 278 m_webViewImpl->page()->settings().setPrimaryHoverType(HoverTypeOnDemand);
279 m_webViewImpl->page()->settings().setResizeIsDeviceSizeChange(true); 279 m_webViewImpl->page()->settings().setResizeIsDeviceSizeChange(true);
280 m_webViewImpl->setZoomFactorOverride(1); 280 m_webViewImpl->setZoomFactorOverride(1);
281 281
282 m_originalDefaultMinimumPageScaleFactor = m_webViewImpl->defaultMinimumPageS caleFactor(); 282 m_originalDefaultMinimumPageScaleFactor = m_webViewImpl->defaultMinimumPageS caleFactor();
283 m_originalDefaultMaximumPageScaleFactor = m_webViewImpl->defaultMaximumPageS caleFactor(); 283 m_originalDefaultMaximumPageScaleFactor = m_webViewImpl->defaultMaximumPageS caleFactor();
284 m_webViewImpl->setDefaultPageScaleLimits(0.25f, 5); 284 m_webViewImpl->setDefaultPageScaleLimits(0.25f, 5);
285 // TODO(dgozman): mainFrameImpl() is null when it's remote. Figure out how 285 // TODO(dgozman): mainFrameImpl() is null when it's remote. Figure out how
286 // we end up with enabling emulation in this case. 286 // we end up with enabling emulation in this case.
287 if (m_webViewImpl->mainFrameImpl()) 287 if (m_webViewImpl->mainFrameImpl())
288 m_webViewImpl->mainFrameImpl()->frameView()->layout(); 288 m_webViewImpl->mainFrameImpl()->frameView()->layout();
289 } 289 }
290 290
291 void DevToolsEmulator::disableMobileEmulation() 291 void DevToolsEmulator::disableMobileEmulation()
292 { 292 {
293 if (!m_emulateMobileEnabled) 293 if (!m_emulateMobileEnabled)
294 return; 294 return;
295 RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(m_isOverlayScrollbarsEna bled); 295 RuntimeEnabledFeatures::setOverlayScrollbarsEnabled(m_isOverlayScrollbarsEna bled);
296 RuntimeEnabledFeatures::setOrientationEventEnabled(m_isOrientationEventEnabl ed); 296 RuntimeEnabledFeatures::setOrientationEventEnabled(m_isOrientationEventEnabl ed);
297 RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(m_isMobileLayoutThemeEna bled); 297 RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(m_isMobileLayoutThemeEna bled);
298 ComputedStyle::invalidateInitialStyle(); 298 ComputedStyle::invalidateInitialStyle();
299 m_webViewImpl->disableViewport(); 299 m_webViewImpl->page()->settings().setViewportEnabled(false);
300 m_webViewImpl->settings()->setViewportMetaEnabled(false); 300 m_webViewImpl->page()->settings().setViewportMetaEnabled(false);
301 m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars(); 301 m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
302 m_webViewImpl->settings()->setShrinksViewportContentToFit(false); 302 m_webViewImpl->settings()->setShrinksViewportContentToFit(false);
303 m_webViewImpl->page()->settings().setTextAutosizingEnabled(m_embedderTextAut osizingEnabled); 303 m_webViewImpl->page()->settings().setTextAutosizingEnabled(m_embedderTextAut osizingEnabled);
304 m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(m_emb edderPreferCompositingToLCDTextEnabled); 304 m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(m_emb edderPreferCompositingToLCDTextEnabled);
305 m_webViewImpl->page()->settings().setUseMobileViewportStyle(m_embedderUseMob ileViewport); 305 m_webViewImpl->page()->settings().setUseMobileViewportStyle(m_embedderUseMob ileViewport);
306 m_webViewImpl->page()->settings().setPluginsEnabled(m_embedderPluginsEnabled ); 306 m_webViewImpl->page()->settings().setPluginsEnabled(m_embedderPluginsEnabled );
307 m_webViewImpl->page()->settings().setAvailablePointerTypes(m_embedderAvailab lePointerTypes); 307 m_webViewImpl->page()->settings().setAvailablePointerTypes(m_embedderAvailab lePointerTypes);
308 m_webViewImpl->page()->settings().setPrimaryPointerType(m_embedderPrimaryPoi nterType); 308 m_webViewImpl->page()->settings().setPrimaryPointerType(m_embedderPrimaryPoi nterType);
309 m_webViewImpl->page()->settings().setAvailableHoverTypes(m_embedderAvailable HoverTypes); 309 m_webViewImpl->page()->settings().setAvailableHoverTypes(m_embedderAvailable HoverTypes);
310 m_webViewImpl->page()->settings().setPrimaryHoverType(m_embedderPrimaryHover Type); 310 m_webViewImpl->page()->settings().setPrimaryHoverType(m_embedderPrimaryHover Type);
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 m_lastPinchAnchorCss.clear(); 382 m_lastPinchAnchorCss.clear();
383 m_lastPinchAnchorDip.clear(); 383 m_lastPinchAnchorDip.clear();
384 } 384 }
385 return true; 385 return true;
386 } 386 }
387 387
388 return false; 388 return false;
389 } 389 }
390 390
391 } // namespace blink 391 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698