Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/web/DevToolsEmulator.cpp

Issue 1787913002: Clear page-defined constraints when viewportEnabled setting becomes false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/DevToolsEmulator.cpp
diff --git a/third_party/WebKit/Source/web/DevToolsEmulator.cpp b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
index 45fa0991e27dce3704816187cad4f1db1f2e89c4..d75cbf58c6b362cd291c8ebdafeb6c21b09b1a57 100644
--- a/third_party/WebKit/Source/web/DevToolsEmulator.cpp
+++ b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
@@ -265,8 +265,8 @@ void DevToolsEmulator::enableMobileEmulation()
RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(true);
ComputedStyle::invalidateInitialStyle();
m_webViewImpl->page()->settings().setUseMobileViewportStyle(true);
- m_webViewImpl->enableViewport();
- m_webViewImpl->settings()->setViewportMetaEnabled(true);
+ m_webViewImpl->page()->settings().setViewportEnabled(true);
+ m_webViewImpl->page()->settings().setViewportMetaEnabled(true);
m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
m_webViewImpl->settings()->setShrinksViewportContentToFit(true);
m_webViewImpl->page()->settings().setTextAutosizingEnabled(true);
@@ -296,8 +296,8 @@ void DevToolsEmulator::disableMobileEmulation()
RuntimeEnabledFeatures::setOrientationEventEnabled(m_isOrientationEventEnabled);
RuntimeEnabledFeatures::setMobileLayoutThemeEnabled(m_isMobileLayoutThemeEnabled);
ComputedStyle::invalidateInitialStyle();
- m_webViewImpl->disableViewport();
- m_webViewImpl->settings()->setViewportMetaEnabled(false);
+ m_webViewImpl->page()->settings().setViewportEnabled(false);
+ m_webViewImpl->page()->settings().setViewportMetaEnabled(false);
m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
m_webViewImpl->settings()->setShrinksViewportContentToFit(false);
m_webViewImpl->page()->settings().setTextAutosizingEnabled(m_embedderTextAutosizingEnabled);
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698