Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1787633003: depot_tools: expose location of ninja (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: expose location of ninja BUG=437264 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299263

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M recipe_modules/depot_tools/api.py View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-12 01:16:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787633003/1
4 years, 9 months ago (2016-03-12 01:16:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-12 01:19:21 UTC) #6
iannucci
lgtm https://codereview.chromium.org/1787633003/diff/1/recipe_modules/depot_tools/api.py File recipe_modules/depot_tools/api.py (right): https://codereview.chromium.org/1787633003/diff/1/recipe_modules/depot_tools/api.py#newcode14 recipe_modules/depot_tools/api.py:14: return self.package_repo_resource('ninja') what about windows? Does this need ...
4 years, 9 months ago (2016-03-12 01:31:59 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/1787633003/diff/1/recipe_modules/depot_tools/api.py File recipe_modules/depot_tools/api.py (right): https://codereview.chromium.org/1787633003/diff/1/recipe_modules/depot_tools/api.py#newcode14 recipe_modules/depot_tools/api.py:14: return self.package_repo_resource('ninja') On 2016/03/12 at 01:31:59, iannucci wrote: > ...
4 years, 9 months ago (2016-03-12 01:36:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1787633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1787633003/1
4 years, 9 months ago (2016-03-12 01:38:33 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 01:41:09 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299263

Powered by Google App Engine
This is Rietveld 408576698