recipe_modules/depot_tools/api.py - Issue 1787633003: depot_tools: expose location of ninja

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/depot_tools/api.py

Issue 1787633003: depot_tools: expose location of ninja (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from recipe_engine import recipe_api	5 from recipe_engine import recipe_api

6	6

7 class DepotToolsApi(recipe_api.RecipeApi):	7 class DepotToolsApi(recipe_api.RecipeApi):

8 @property	8 @property

9 def download_from_google_storage_path(self):	9 def download_from_google_storage_path(self):

10 return self.package_repo_resource('download_from_google_storage.py')	10 return self.package_repo_resource('download_from_google_storage.py')

	11

	12 @property

	13 def ninja_path(self):

	14 return self.package_repo_resource('ninja')
	iannucci 2016/03/12 01:31:59 what about windows? Does this need to be ninja.exe what about windows? Does this need to be ninja.exe there? Paweł Hajdan Jr. 2016/03/12 01:36:46 I tested on my Windows machine and ninja works. Cu Show quoted text On 2016/03/12 at 01:31:59, iannucci wrote: > what about windows? Does this need to be ninja.exe there? I tested on my Windows machine and ninja works. Currently compile.py also uses ninja on all platforms (although I can imagine it working differently with just tool name + PATH lookup vs. full path, which is why I checked on actual Windows).
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »