recipe_modules/depot_tools/api.py - Issue 1787633003: depot_tools: expose location of ninja

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/depot_tools/api.py

Issue 1787633003: depot_tools: expose location of ninja (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/depot_tools/api.py

diff --git a/recipe_modules/depot_tools/api.py b/recipe_modules/depot_tools/api.py

index 7ee9e059024daaeb2712c09034cf9e0f2f8224d7..8dfc8a11b8c9932e443476998a03aa06f7845487 100644

--- a/recipe_modules/depot_tools/api.py

+++ b/recipe_modules/depot_tools/api.py

@@ -8,3 +8,7 @@ class DepotToolsApi(recipe_api.RecipeApi):

@property

def download_from_google_storage_path(self):

return self.package_repo_resource('download_from_google_storage.py')

+ @property

+ def ninja_path(self):

+ return self.package_repo_resource('ninja')

iannucci 2016/03/12 01:31:59 what about windows? Does this need to be ninja.exe

Paweł Hajdan Jr. 2016/03/12 01:36:46 I tested on my Windows machine and ninja works. Cu

« no previous file with comments | « no previous file | no next file » | no next file with comments »