Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1786623002: [testing] Convert "non-alphanum" to be a "message" test. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-preparser-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[testing] Convert "non-alphanum" to be a "message" test. This converts another test case that is expected to throw a TypeError but no SyntaxError to have better test coverage (exact message is being checked now). R=machenbach@chromium.org TEST=message,preparser Committed: https://crrev.com/6a629ff7a956a4be7326d52c2cb904845c28abc9 Cr-Commit-Position: refs/heads/master@{#34715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -70 lines) Patch
A + test/message/non-alphanum.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/message/non-alphanum.out View 1 chunk +5 lines, -33 lines 0 comments Download
D test/preparser/non-alphanum.js View 1 chunk +0 lines, -34 lines 0 comments Download
M test/preparser/preparser.status View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Michael: PTAL. Adam: FYI, one more.
4 years, 9 months ago (2016-03-11 10:16:12 UTC) #2
Michael Achenbach
lgtm
4 years, 9 months ago (2016-03-11 10:48:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786623002/1
4 years, 9 months ago (2016-03-11 11:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 11:36:01 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 11:36:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a629ff7a956a4be7326d52c2cb904845c28abc9
Cr-Commit-Position: refs/heads/master@{#34715}

Powered by Google App Engine
This is Rietveld 408576698