[testing] Convert some "preparser" tests into "message".

[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser

Committed: https://crrev.com/57ef4f4f3a4716502c808e54a81c71d77842083b
Cr-Commit-Position: refs/heads/master@{#34713}

[Michael Starzinger, 2016-03-11 10:01:36]

mstarzinger@chromium.org changed reviewers:
+ adamk@chromium.org

[Michael Starzinger, 2016-03-11 10:01:36]

Michael: PTAL.
Adam: FYI, what we discussed a couple of weeks ago.

[Michael Starzinger, 2016-03-11 10:05:48]

Description was changed from

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by not to just check
whether each test case threw or not, the exception message is not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=messages,preparser
==========

to

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=messages,preparser
==========

[Michael Starzinger, 2016-03-11 10:06:10]

Description was changed from

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=messages,preparser
==========

to

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser
==========

[Michael Achenbach, 2016-03-11 10:52:52]

LGTM. Didn't check the exact content of each out file. I'm trusting that
whatever is in there is the current baseline.

[Michael Starzinger, 2016-03-11 10:57:12]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-03-11 10:57:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784013003/1

[commit-bot: I haz the power, 2016-03-11 10:59:00]

Description was changed from

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser
==========

to

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser
==========

[commit-bot: I haz the power, 2016-03-11 10:59:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 11:00:17]

Description was changed from

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser
==========

to

==========
[testing] Convert some "preparser" tests into "message".

This converts existing "preparser" tests that expect a certain exception
message to be produced into "message" tests. Thereby we get much better
coverage because the former test suite degraded by now to just check
whether each test case threw or not, the exception message was not being
checked at all.

This also deprecates the ability of "preparser" to specify that single
test cases based on JS files are expected to throw, "messages" is far
superior, use that test suite instead.

R=machenbach@chromium.org
TEST=message,preparser

Committed: https://crrev.com/57ef4f4f3a4716502c808e54a81c71d77842083b
Cr-Commit-Position: refs/heads/master@{#34713}
==========

[commit-bot: I haz the power, 2016-03-11 11:00:18]

Patchset 1 (id:??) landed as
https://crrev.com/57ef4f4f3a4716502c808e54a81c71d77842083b
Cr-Commit-Position: refs/heads/master@{#34713}