[testing] Move the last JS tests out of "preparser".

[testing] Move the last JS tests out of "preparser".

This moves the last remaining JS file based tests out of the "preparser"
suite. The tests in question all are expected to parse normally and not
throw any exception. This also deprecates the ability of the test suite
to run anything else outside Python templated tests.

R=adamk@chromium.org
TEST=preparser

Committed: https://crrev.com/a02b7aaa6d4d1ebd45059e1191ebed44fa000445
Cr-Commit-Position: refs/heads/master@{#34753}

[Michael Starzinger, 2016-03-11 14:17:13]

Hey Adam, I vaguely remember from the last time we chatted that you weren't all
that happy about empty .out files in the message test suite. But I cannot recall
whether we arrived at an alternative conclusion back then. What is your take on
this?

[adamk, 2016-03-11 21:40:28]

I recall the discussion, but I don't remember objecting :)

I think the empty .out files are fine. But some comments on the actual tests
themselves.

https://codereview.chromium.org/1782173005/diff/20001/test/message/empty.js
File test/message/empty.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/empty.js#n...
test/message/empty.js:28: // This file contains no JavaScript code.
Not sure what we're testing here, can we just delete this? We're definitely not
testing the preparser anymore.

https://codereview.chromium.org/1782173005/diff/20001/test/message/functions-...
File test/message/functions-only.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/functions-...
test/message/functions-only.js:28: // This file contains no identifiers or
string literals, but does contain
Again, unclear what this is testing.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-arguments.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-arguments.js:30: var arguments = 42;
If you want this test to exercise the preparser you'll need to wrap it in a
function.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-eval.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-eval.js:30: var eval = 42;
Same here, wrap with a function.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-with.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-with.js:31: with ({}) {}
And here too.

[Michael Starzinger, 2016-03-14 12:14:17]

Thanks! Addressed comments.

https://codereview.chromium.org/1782173005/diff/20001/test/message/empty.js
File test/message/empty.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/empty.js#n...
test/message/empty.js:28: // This file contains no JavaScript code.
On 2016/03/11 21:40:28, adamk wrote:
> Not sure what we're testing here, can we just delete this? We're definitely
not
> testing the preparser anymore.

Done. You are right, I removed it.

https://codereview.chromium.org/1782173005/diff/20001/test/message/functions-...
File test/message/functions-only.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/functions-...
test/message/functions-only.js:28: // This file contains no identifiers or
string literals, but does contain
On 2016/03/11 21:40:28, adamk wrote:
> Again, unclear what this is testing.

Done. You are right, I removed it.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-arguments.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-arguments.js:30: var arguments = 42;
On 2016/03/11 21:40:28, adamk wrote:
> If you want this test to exercise the preparser you'll need to wrap it in a
> function.

Done.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-eval.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-eval.js:30: var eval = 42;
On 2016/03/11 21:40:28, adamk wrote:
> Same here, wrap with a function.

Done.

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
File test/message/nonstrict-with.js (right):

https://codereview.chromium.org/1782173005/diff/20001/test/message/nonstrict-...
test/message/nonstrict-with.js:31: with ({}) {}
On 2016/03/11 21:40:28, adamk wrote:
> And here too.

Done.

[adamk, 2016-03-14 16:38:18]

lgtm

[Michael Starzinger, 2016-03-14 16:45:27]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-03-14 16:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782173005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782173005/40001

[commit-bot: I haz the power, 2016-03-14 17:08:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-14 17:10:58]

Description was changed from

==========
[testing] Move the last JS tests out of "preparser".

This moves the last remaining JS file based tests out of the "preparser"
suite. The tests in question all are expected to parse normally and not
throw any exception. This also deprecates the ability of the test suite
to run anything else outside Python templated tests.

R=adamk@chromium.org
TEST=preparser
==========

to

==========
[testing] Move the last JS tests out of "preparser".

This moves the last remaining JS file based tests out of the "preparser"
suite. The tests in question all are expected to parse normally and not
throw any exception. This also deprecates the ability of the test suite
to run anything else outside Python templated tests.

R=adamk@chromium.org
TEST=preparser

Committed: https://crrev.com/a02b7aaa6d4d1ebd45059e1191ebed44fa000445
Cr-Commit-Position: refs/heads/master@{#34753}
==========

[commit-bot: I haz the power, 2016-03-14 17:10:58]

Patchset 3 (id:??) landed as
https://crrev.com/a02b7aaa6d4d1ebd45059e1191ebed44fa000445
Cr-Commit-Position: refs/heads/master@{#34753}