Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178613003: Make Document::nodeChildrenWillBeRemoved() take a reference (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Make Document::nodeChildrenWillBeRemoved() take a reference Make Document::nodeChildrenWillBeRemoved() take a reference instead of a pointer as the pointer was always expected to be non-null. This makes the code look safer and avoids having assertions. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167734

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use PassRefPtr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
M Source/core/dom/RangeBoundaryPoint.h View 1 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 10 months ago (2014-02-24 22:07:31 UTC) #1
adamk
lgtm with nit (about which I may well be wrong) https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h File Source/core/dom/RangeBoundaryPoint.h (right): https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h#newcode149 ...
6 years, 10 months ago (2014-02-24 22:15:00 UTC) #2
Inactive
https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h File Source/core/dom/RangeBoundaryPoint.h (right): https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h#newcode149 Source/core/dom/RangeBoundaryPoint.h:149: m_containerNode = RefPtr<Node>(container); On 2014/02/24 22:15:00, adamk wrote: > ...
6 years, 10 months ago (2014-02-24 22:21:08 UTC) #3
Inactive
https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h File Source/core/dom/RangeBoundaryPoint.h (right): https://codereview.chromium.org/178613003/diff/1/Source/core/dom/RangeBoundaryPoint.h#newcode149 Source/core/dom/RangeBoundaryPoint.h:149: m_containerNode = RefPtr<Node>(container); On 2014/02/24 22:15:00, adamk wrote: > ...
6 years, 10 months ago (2014-02-24 22:36:13 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-24 22:36:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178613003/20001
6 years, 10 months ago (2014-02-24 22:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178613003/20001
6 years, 10 months ago (2014-02-25 01:06:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178613003/20001
6 years, 10 months ago (2014-02-25 05:17:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 06:45:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 167734

Powered by Google App Engine
This is Rietveld 408576698