Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 178613003: Make Document::nodeChildrenWillBeRemoved() take a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use PassRefPtr Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Range.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3579 matching lines...) Expand 10 before | Expand all | Expand 10 after
3590 3590
3591 void Document::updateRangesAfterChildrenChanged(ContainerNode* container) 3591 void Document::updateRangesAfterChildrenChanged(ContainerNode* container)
3592 { 3592 {
3593 if (!m_ranges.isEmpty()) { 3593 if (!m_ranges.isEmpty()) {
3594 HashSet<Range*>::const_iterator end = m_ranges.end(); 3594 HashSet<Range*>::const_iterator end = m_ranges.end();
3595 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it) 3595 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it)
3596 (*it)->nodeChildrenChanged(container); 3596 (*it)->nodeChildrenChanged(container);
3597 } 3597 }
3598 } 3598 }
3599 3599
3600 void Document::nodeChildrenWillBeRemoved(ContainerNode* container) 3600 void Document::nodeChildrenWillBeRemoved(ContainerNode& container)
3601 { 3601 {
3602 NoEventDispatchAssertion assertNoEventDispatch; 3602 NoEventDispatchAssertion assertNoEventDispatch;
3603 if (!m_ranges.isEmpty()) { 3603 if (!m_ranges.isEmpty()) {
3604 HashSet<Range*>::const_iterator end = m_ranges.end(); 3604 HashSet<Range*>::const_iterator end = m_ranges.end();
3605 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it) 3605 for (HashSet<Range*>::const_iterator it = m_ranges.begin(); it != end; + +it)
3606 (*it)->nodeChildrenWillBeRemoved(container); 3606 (*it)->nodeChildrenWillBeRemoved(container);
3607 } 3607 }
3608 3608
3609 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d(); 3609 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d();
3610 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) { 3610 for (HashSet<NodeIterator*>::const_iterator it = m_nodeIterators.begin(); it != nodeIteratorsEnd; ++it) {
3611 for (Node* n = container->firstChild(); n; n = n->nextSibling()) 3611 for (Node* n = container.firstChild(); n; n = n->nextSibling())
3612 (*it)->nodeWillBeRemoved(*n); 3612 (*it)->nodeWillBeRemoved(*n);
3613 } 3613 }
3614 3614
3615 if (Frame* frame = this->frame()) { 3615 if (Frame* frame = this->frame()) {
3616 for (Node* n = container->firstChild(); n; n = n->nextSibling()) { 3616 for (Node* n = container.firstChild(); n; n = n->nextSibling()) {
3617 frame->eventHandler().nodeWillBeRemoved(*n); 3617 frame->eventHandler().nodeWillBeRemoved(*n);
3618 frame->selection().nodeWillBeRemoved(*n); 3618 frame->selection().nodeWillBeRemoved(*n);
3619 frame->page()->dragCaretController().nodeWillBeRemoved(*n); 3619 frame->page()->dragCaretController().nodeWillBeRemoved(*n);
3620 } 3620 }
3621 } 3621 }
3622 } 3622 }
3623 3623
3624 void Document::nodeWillBeRemoved(Node& n) 3624 void Document::nodeWillBeRemoved(Node& n)
3625 { 3625 {
3626 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d(); 3626 HashSet<NodeIterator*>::const_iterator nodeIteratorsEnd = m_nodeIterators.en d();
(...skipping 1814 matching lines...) Expand 10 before | Expand all | Expand 10 after
5441 void Document::defaultEventHandler(Event* event) 5441 void Document::defaultEventHandler(Event* event)
5442 { 5442 {
5443 if (frame() && frame()->remotePlatformLayer()) { 5443 if (frame() && frame()->remotePlatformLayer()) {
5444 frame()->chromeClient().forwardInputEvent(this, event); 5444 frame()->chromeClient().forwardInputEvent(this, event);
5445 return; 5445 return;
5446 } 5446 }
5447 Node::defaultEventHandler(event); 5447 Node::defaultEventHandler(event);
5448 } 5448 }
5449 5449
5450 } // namespace WebCore 5450 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Range.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698